GODRIVER-2722 Remove/unexport unnecessary interfaces. #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./bsonincompatible changesBytesReader: removed |
prestonvasquez
previously approved these changes
Jun 10, 2024
matthewdale
reviewed
Jun 15, 2024
bson/primitive.go
Outdated
Comment on lines
22
to
23
| type zeroer interface { | ||
| IsZero() bool |
There was a problem hiding this comment.
Considering the recent relevance of IsZero, it's possible we may need to keep the Zeroer interface exported.
matthewdale
reviewed
Jun 26, 2024
bson/proxy.go
Outdated
Comment on lines
12
to
13
| type proxy interface { | ||
| ProxyBSON() (interface{}, error) |
There was a problem hiding this comment.
We should consider completely removing the ProxyBSON feature. Based on searching for uses in open-source repos, it seems completely unused.
bson/struct_codec.go
Outdated
Comment on lines
184
to
187
| if cz, ok := encoder.(interface { | ||
| IsTypeZero(interface{}) bool | ||
| }); ok { | ||
| empty = cz.IsTypeZero(rv.Interface()) |
There was a problem hiding this comment.
We should consider completely removing the IsTypeZero feature. Based on searching for uses in open-source repos, it seems completely unused.
qingyang-hu
force-pushed
the
godriver2722
branch
from
a6be53c
to
c3709b4
Compare
prestonvasquez
previously approved these changes
Jun 27, 2024
qingyang-hu
dismissed stale reviews from matthewdale and prestonvasquez
via
39f33cd
matthewdale
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2722
Summary
Remove/un-export unnecessary interfaces.