Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-1695 always use heartbeatTimeout for heartbeat connection #470

Merged
merged 3 commits into from
Jul 30, 2020
Merged

GODRIVER-1695 always use heartbeatTimeout for heartbeat connection #470

merged 3 commits into from
Jul 30, 2020

Conversation

iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Jul 28, 2020

No description provided.

@iwysiu iwysiu requested review from divjotarora and jyemin July 28, 2020 22:08
divjotarora
divjotarora reviewed Jul 29, 2020
View reviewed changes
Copy link
Contributor

@divjotarora divjotarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to unit test this in server_test.go by making a Server that has a socket timeout set in its connectionOpts and ensuring that the timeout is overridden on all connections made by the createConnection function.

x/mongo/driver/topology/server.go Show resolved Hide resolved
@iwysiu iwysiu mentioned this pull request Jul 29, 2020
Closed
divjotarora
divjotarora reviewed Jul 29, 2020
View reviewed changes
x/mongo/driver/topology/server_test.go Outdated Show resolved Hide resolved
x/mongo/driver/topology/server_test.go Outdated Show resolved Hide resolved
jyemin
jyemin approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iwysiu iwysiu merged commit a8b8f62 into mongodb:master Jul 30, 2020
iwysiu pushed a commit that referenced this pull request Jul 30, 2020
GODRIVER-1695 always use heartbeatTimeout for heartbeat connection (#470
d3ceaf3 
)
iwysiu pushed a commit that referenced this pull request Jul 30, 2020
GODRIVER-1695 always use heartbeatTimeout for heartbeat connection (#470
61c3712 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divjotarora divjotarora divjotarora approved these changes

@jyemin jyemin jyemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwysiu @jyemin @divjotarora