Test expressions in context #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katcharov
commented
Dec 9, 2022
There was a problem hiding this comment.
Was reading docs match(expr(new Document("$and", seems that we might add a version of expr such that the above would become:
Filters.expr(d -> d.getInteger("x").eq(of(1))
There was a problem hiding this comment.
I am imagining that this could be something for the future.
jyemin
reviewed
Dec 13, 2022
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
katcharov
force-pushed
the
expressions-switch2
branch
from
d89bcad to
56e8756
Compare
katcharov
force-pushed
the
expressions-context
branch
from
7b0fde5 to
52776b6
Compare
stIncMale
requested changes
Jan 11, 2023
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java
Outdated
Show resolved
Hide resolved
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java
Outdated
Show resolved
Hide resolved
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I am imagining that this could be something for the future.
stIncMale
reviewed
Jan 17, 2023
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java
Outdated
Show resolved
Hide resolved
stIncMale
requested changes
Jan 17, 2023
...test/functional/com/mongodb/client/model/expressions/InContextExpressionsFunctionalTest.java
Show resolved
Hide resolved
stIncMale
approved these changes
Jan 17, 2023
stIncMale
requested changes
Jan 17, 2023
driver-core/src/main/com/mongodb/client/model/expressions/Expressions.java
Outdated
Show resolved
Hide resolved
stIncMale
approved these changes
Jan 18, 2023
katcharov
force-pushed
the
expressions-switch2
branch
2 times, most recently
from
e71ebd8 to
1449f2f
Compare
katcharov
force-pushed
the
expressions-context
branch
from
f6e5a14 to
1fb5893
Compare
|
Rebased, no conflicts |
katcharov
force-pushed
the
expressions-switch2
branch
from
5dd9987 to
647e307
Compare
katcharov
force-pushed
the
expressions-context
branch
from
1fb5893 to
458d786
Compare
katcharov
added a commit
that referenced
this pull request
Jan 30, 2023
katcharov
added a commit
that referenced
this pull request
Jan 31, 2023
katcharov
added a commit
that referenced
this pull request
Jan 31, 2023
* Implement boolean expressions (#1025) JAVA-4779 * Implement filter, map, reduce (#1031) JAVA-4781 * Implement eq, ne, gt, gte, lt, lte (#1033) JAVA-4784 * Implement string expressions (#1036) JAVA-4801 * Implement arithmetic expressions (#1037) Implement arithmetic expressions (from top 50, and others) JAVA-4803 * Implement array expressions (#1043) JAVA-4805 * Implement date expressions (#1045) JAVA-4804 * Implement conversion/type expressions (#1050) JAVA-4802 * Implement document expressions (#1052) JAVA-4782 * Replace reduce with individual reductions (#1053) JAVA-4814 * Implement map expressions (#1054) JAVA-4817 * Implement switch expression (#1055) JAVA-4813 * Test expressions in context (#1057) JAVA-4820 * Add javadoc for boolean, date, number, integer, and expression (#1059) JAVA-4799 * Update and add documentation (#1059) * Fix, tests JAVA-4799 * Add `@MqlUnchecked` and a few usage examples (#1059) JAVA-4799 * Add has to document, add tests (#1070) JAVA-4799 * Add javadocs for remaining classes (#1070) JAVA-4799 * 5.2 annotations (#1070) JAVA-4799 * 5.0 annotations (#1070) JAVA-4799 * 4.4 annotations (#1070) JAVA-4799 * 4.2 annotations (#1070) JAVA-4799 * 4.0 annotations (#1070) JAVA-4799 * Update and add documentation, add tests, fix minor issues (#1070) Rename extractBsonValue Fix access modifiers Remove excess comments Update docs Fix: behaviour of get Add notNull to API, add notNullApi test Fix docs/annotations, tests Fix docs, annotations, since Fix docs Revert external Add missing MqlUnchecked Fix missing null checks Checkstyle JAVA-4799 * Rename to Mql (automated) (#1073) JAVA-3879 * Rename methods (automated) (#1073) JAVA-3879 * Update naming, terms, and missing checks and annotations (#1073) JAVA-3879 --------- Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4820