Skip to content

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Mar 28, 2023

@jyemin jyemin requested a review from katcharov March 28, 2023 19:15
@jyemin jyemin self-assigned this Mar 28, 2023
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this unused file rather than fix it to use the new API.

* @since 4.4
* @deprecated Prefer {@link CommandEvent#CommandEvent(RequestContext, long, int, ConnectionDescription, String)}
*/
@Deprecated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of annoying that we have to preserve BC on constructors like this but it's what we do.

Copy link
Collaborator

@katcharov katcharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of questions.

@jyemin jyemin merged commit 7bdd1d7 into mongodb:master Mar 30, 2023
@jyemin jyemin deleted the j4907-command-events branch March 30, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants