Refactor to use Timeout for server selection #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
requested changes
Sep 26, 2023
| } else { | ||
| // the timeout will track this remaining time | ||
| //noinspection ResultOfMethodCallIgnored | ||
| latch.await(this.remaining(NANOSECONDS), NANOSECONDS); |
There was a problem hiding this comment.
The result of the latch needs to be inspected - as if it returns false it awaited the time limit but wasn't counted down.
There was a problem hiding this comment.
Previously, the 3 usages, all in BaseCluster, that were refactored into this method did not inspect the result. (Perhaps they should have inspected the result, but I could not readily see the error.)
|
Looking good - much easier to read, couple of comments / questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5175
This uses Timeout for timeout logic, and ensures that settings are obtained from one location, for consistency with how settings will be obtained from the recently-merged TimeoutSettings (though, this is not used, as it is not yet propagated into OperationContext).