Remove deprecated ServerAddress methods #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ServerAddress#getSocketAddress * ServerAddress#getSocketAddresses * UnixServerAddress#getSocketAddress * UnixServerAddress#getUnixSocketAddress JAVA-4937
jyemin
commented
Oct 17, 2023
driver-core/src/main/com/mongodb/internal/connection/ServerAddressHelper.java
Show resolved
Hide resolved
stIncMale
requested changes
Oct 20, 2023
driver-core/src/main/com/mongodb/internal/connection/netty/NettyStreamFactoryFactory.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/connection/ConnectionPoolAsyncTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/connection/StreamFactoryHelperTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/connection/netty/NettyStreamSpecification.groovy
Show resolved
Hide resolved
…ectionPoolAsyncTest.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
jyemin
commented
Oct 20, 2023
driver-core/src/main/com/mongodb/internal/connection/netty/NettyStreamFactoryFactory.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/connection/StreamFactoryHelperTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/connection/netty/NettyStreamSpecification.groovy
Show resolved
Hide resolved
stIncMale
approved these changes
Oct 21, 2023
jyemin
added a commit
that referenced
this pull request
Dec 4, 2023
* ServerAddress#getSocketAddress * ServerAddress#getSocketAddresses * UnixServerAddress#getSocketAddress * UnixServerAddress#getUnixSocketAddress JAVA-4937
jyemin
added a commit
that referenced
this pull request
Dec 5, 2023
* ServerAddress#getSocketAddress * ServerAddress#getSocketAddresses * UnixServerAddress#getSocketAddress * UnixServerAddress#getUnixSocketAddress JAVA-4937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4937
Design Notes:
ServerAddressWithResolverand instead push theInetAddressResolverdown to theStreamimplementationsDefaultInetAddressResolverto replicate the removedServerAddressmethod and avoid having to make the resolver nullable everywhere