Skip to content

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Feb 21, 2024

Due to all the secrets still being echoed on the Gradle command line in the previous PR, this second attempt replaces all the Gradle system properties with environment variables. As a result, a lot of code had to change but they were all fairly mechanical transformations (though not automated).

JAVA-5311

@jyemin jyemin requested review from dylrich and rozza February 22, 2024 00:26
@jyemin jyemin marked this pull request as ready for review February 22, 2024 00:26
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dylrich dylrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyemin jyemin merged commit 140bdce into mongodb:master Feb 26, 2024
@jyemin jyemin deleted the j5311-2 branch February 26, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants