Skip to content

Deprecate timeout options. #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2024
Merged

Deprecate timeout options. #1346

merged 3 commits into from
Mar 22, 2024

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin requested a review from rozza March 19, 2024 02:51
@vbabanin vbabanin marked this pull request as ready for review March 19, 2024 02:51
rozza
rozza requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Couple of things:

  • Scaladoc formatting seems off (extra spacing)
  • Run: ./gradlew clean check --continue -xtest -xintegrationTest and see if you can suppress some of the deprecation warnings.

@rozza
Copy link
Member

rozza commented Mar 19, 2024

I added JAVA-5373 to ensure MongoClient gets added to the doc examples, to not delay this or the other PR.

@vbabanin
Correct javadoc.
f1c7c7e 
JAVA-5290
@vbabanin vbabanin requested a review from rozza March 22, 2024 00:26
rozza
rozza approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some warnings - so rather than potentially delaying the merge I fixed up and pushed to your branch.

Also deprecated dropIndexOptions.maxTime and preferred using @Suppress("DEPRECATION") on methods as opposed to being inline - doesn't hinder readability.

LGTM - but please make sure you're happy with my commit.

@vbabanin
Copy link
Member Author

Thanks for the fixes and handling the deprecation warnings @rozza! LGTM!

@vbabanin vbabanin merged commit 3f41bf4 into mongodb:CSOT Mar 22, 2024
vbabanin added a commit to vbabanin/mongo-java-driver that referenced this pull request Apr 17, 2024
@vbabanin
Revert "Deprecate timeout options. (mongodb#1346)"
4888c4d 
This reverts commit 3f41bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rozza rozza rozza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbabanin @rozza