Extend Socks5 TLD regex validation to support up to 63 characters #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…haracters to comply with RFC 1034 standard. JAVA-5490
|
Only question: Should there be a drivers ticket for this change (for those drivers that regex validate TLDs)? Maybe a prose test? |
Thanks for your question. There’s no need for a driver's ticket as the regex validation of domain names is only implemented in Java driver. |
vbabanin
added a commit
to vbabanin/mongo-java-driver
that referenced
this pull request
Jun 28, 2024
…haracters to comply with RFC 1034 standard. (mongodb#1427) JAVA-5490 (cherry picked from commit e4b8a83)
vbabanin
added a commit
to vbabanin/mongo-java-driver
that referenced
this pull request
Jun 28, 2024
…haracters to comply with RFC 1034 standard. (mongodb#1427) JAVA-5490
vbabanin
added a commit
to vbabanin/mongo-java-driver
that referenced
this pull request
Jun 28, 2024
…haracters to comply with RFC 1034 standard. (mongodb#1427) JAVA-5490
stIncMale
pushed a commit
that referenced
this pull request
Jun 28, 2024
stIncMale
pushed a commit
that referenced
this pull request
Jun 28, 2024
stIncMale
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Modified the regex pattern to support top-level domain (TLD) lengths of up to 63 characters, in accordance with RFC 1034 standards.
Purpose:
This update ensures our regex can handle the 'internal' TLD used in EC2 guest OS hostnames, thus increasing the flexibility of TLD validation.
JAVA-5490