Skip to content

Remove redundant switchIfEmptyStage #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Remove redundant switchIfEmptyStage #1455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...e-streams/src/main/com/mongodb/reactivestreams/client/internal/OperationExecutorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ public <T> Mono<T> execute(final AsyncReadOperation<T> operation, final ReadPref
clientSessionHelper.withClientSession(session, this)
.map(clientSession -> getReadWriteBinding(getContext(subscriber),
readPreference, readConcern, clientSession, session == null))
// TODO (CSOT) - does this get called - can the above return empty?
.switchIfEmpty(Mono.fromCallable(() ->
getReadWriteBinding(getContext(subscriber),
readPreference, readConcern, session, false)))
.flatMap(binding -> {
if (session != null && session.hasActiveTransaction() && !binding.getReadPreference().equals(primary())) {
binding.release();
Expand Down Expand Up @@ -122,10 +118,6 @@ public <T> Mono<T> execute(final AsyncWriteOperation<T> operation, final ReadCon
clientSessionHelper.withClientSession(session, this)
.map(clientSession -> getReadWriteBinding(getContext(subscriber),
primary(), readConcern, clientSession, session == null))
// TODO (CSOT) - does this get called - can the above return empty?
.switchIfEmpty(Mono.fromCallable(() ->
getReadWriteBinding(getContext(subscriber), primary(),
readConcern, session, false)))
.flatMap(binding ->
Mono.<T>create(sink -> operation.executeAsync(binding, (result, t) -> {
try {
Expand Down