Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate unnecessary killCursors command when batchSize == limit #1656

Merged
merged 4 commits into from
Mar 26, 2025
Merged

Eliminate unnecessary killCursors command when batchSize == limit #1656

merged 4 commits into from
Mar 26, 2025

Conversation

NathanQingyangXu
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu commented Mar 24, 2025 •
edited
Loading

@NathanQingyangXu NathanQingyangXu marked this pull request as draft March 24, 2025 21:16
@NathanQingyangXu NathanQingyangXu changed the title Java 5667 Eliminate unnecessary killCursors command when batchSize == limit Mar 24, 2025
@NathanQingyangXu NathanQingyangXu marked this pull request as ready for review March 24, 2025 23:22
@NathanQingyangXu NathanQingyangXu requested a review from jyemin March 24, 2025 23:22
jyemin
jyemin requested changes Mar 24, 2025
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of apparent code duplication here. I suggest you have a look at the FindOperation class and see if you can consolidate all the logic there, at the point where the action command document is created.

@NathanQingyangXu NathanQingyangXu requested a review from jyemin March 25, 2025 17:45
@NathanQingyangXu NathanQingyangXu requested a review from jyemin March 26, 2025 12:30
jyemin
jyemin approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When you create the squashed commit, please observe the driver practice of putting the issue number on a separate line, e.g.

This is the description

JAVA-XXXX

@NathanQingyangXu NathanQingyangXu merged commit 1090b3f into main Mar 26, 2025
60 checks passed
@NathanQingyangXu NathanQingyangXu deleted the JAVA-5667 branch March 26, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyemin jyemin jyemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanQingyangXu @jyemin