Skip to content

Conversation

NathanQingyangXu
Copy link
Contributor

@NathanQingyangXu NathanQingyangXu marked this pull request as ready for review July 18, 2025 20:26
@NathanQingyangXu NathanQingyangXu requested a review from a team as a code owner July 18, 2025 20:26
@NathanQingyangXu NathanQingyangXu requested review from nhachicha and removed request for a team July 18, 2025 20:26
@NathanQingyangXu
Copy link
Contributor Author

I could delete the driver-workload-executor module, but then the following two checks would fail:

  • license/snyk
  • security/snyk

Could we delete the module without issue?

Copy link
Contributor

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to update the submodule to sync the tests format as described in https://jira.mongodb.org/browse/JAVA-5798

@NathanQingyangXu
Copy link
Contributor Author

https://jira.mongodb.org/browse/JAVA-5798

@rozza , we have stopped cloning local unified testing cases but grabbed by fetching from upstream at run time, correct?

@jyemin
Copy link
Collaborator

jyemin commented Jul 22, 2025

I could delete the driver-workload-executor module, but then the following two checks would fail:

Why would they fail exactly?

@NathanQingyangXu
Copy link
Contributor Author

I could delete the driver-workload-executor module, but then the following two checks would fail:

Why would they fail exactly?

That is a mystery to me as well. We should delete driver-workload-executor module, right?

@rozza
Copy link
Member

rozza commented Jul 23, 2025

@rozza , we have stopped cloning local unified testing cases but grabbed by fetching from upstream at run time, correct?
Correct - I've just merged the latest dependabot commit - so we're up to date.

@NathanQingyangXu
Copy link
Contributor Author

I could delete the driver-workload-executor module, but then the following two checks would fail:

Why would they fail exactly?

I found the reason. We need to change snyk scanning config to remove the module. Now the snyk issues are gone.

Copy link
Contributor

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jyemin
Copy link
Collaborator

jyemin commented Aug 4, 2025

We need to change snyk scanning config to remove the module. Now the snyk issues are gone.

Just curious where this had to be done, as I don't see anything in the PR itself.

@NathanQingyangXu
Copy link
Contributor Author

NathanQingyangXu commented Aug 4, 2025 via email

@NathanQingyangXu NathanQingyangXu merged commit 5e61b7a into main Aug 7, 2025
52 of 55 checks passed
@NathanQingyangXu NathanQingyangXu deleted the JAVA-5798 branch August 7, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants