KAFKA-388: Add NullFieldValueRemover post processor #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arahmanan
reviewed
Nov 18, 2024
| @@ -5,7 +5,7 @@ | |||
| ## 1.13.1 | |||
|
|
|||
| ### Bug Fixes | |||
| - [KAFKA-428](https://jira.mongodb.org/browse/KAFKA-428) Avoid unnecessary copy of data on restart | |||
| - [KAFKA-428](https://jira.mongodb.org/browse/KAFKA-428) Avoid unnecessary copy of data on restart | |||
There was a problem hiding this comment.
[opt/q] was this intentional?
There was a problem hiding this comment.
Yeah my IDE kept fixing this automatically so I thought I'd just go ahead and commit this fix.
|
|
||
| assertEquals(Optional.of(expected), sinkDocWithValueDoc.getValueDoc()); | ||
|
|
||
| elements = |
There was a problem hiding this comment.
[opt] Thoughts on breaking this into multiple test functions for clarity?
| @Test | ||
| @DisplayName("test NullFieldValueRemoverTest nested document") | ||
| void testNullFieldValueRemoverNestedDocument() { | ||
| List<BsonElement> elements = |
There was a problem hiding this comment.
[q] I find this format a little hard to read. Would something similar to this test work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new post processor to support removing fields that have null values.
e.g.
{ foo: { a: null, b: 1, c: null } }is transformed into{ foo: { b: 1 } }{ foo: { 'myNull1': null, 'myNull2': null, 'myNull3': null } }is transformed into{ foo: {} }{ 'myArray': ['a', {'myArrayValueDocumentNull1': null}] }is transformed into{ 'myArray': ['a', {}] }note that null elements in arrays will be kept
'myArray': [null, 'a']is not impacted'myArray': [null, 'a']