KAFKA-165: Add change.stream.show.expanded.events property #172
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,7 @@ | |
|
|
||
| import java.time.Instant; | ||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Locale; | ||
|
|
@@ -1053,6 +1054,144 @@ void testFullDocumentBeforeChange() { | |
| } | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Ensure disambiguatedPaths exist when showExpandedEvents is true") | ||
| void testDisambiguatedPathsExistWhenShowExpandedEventsIsTrue() { | ||
| assumeTrue(isAtLeastSevenDotZero()); | ||
| MongoDatabase db = getDatabaseWithPostfix(); | ||
| try (AutoCloseableSourceTask task = createSourceTask()) { | ||
| MongoCollection<Document> coll = db.getCollection("coll"); | ||
| coll.drop(); | ||
| db.createCollection(coll.getNamespace().getCollectionName(), new CreateCollectionOptions()); | ||
| HashMap<String, String> cfg = new HashMap<>(); | ||
| cfg.put( | ||
| MongoSourceConfig.OUTPUT_FORMAT_VALUE_CONFIG, | ||
| OutputFormat.SCHEMA.name().toLowerCase(Locale.ROOT)); | ||
| cfg.put(MongoSourceConfig.SHOW_EXPANDED_EVENTS_CONFIG, "true"); | ||
| task.start(cfg); | ||
| int id = 0; | ||
| Document expected = new Document("_id", id); | ||
| coll.insertOne(expected); | ||
| coll.updateOne(Filters.eq(id), Document.parse("{ $set: { foo: 1 } }")); | ||
| coll.deleteOne(Filters.eq(id)); | ||
| List<SourceRecord> records = getNextResults(task); | ||
| assertEquals(3, records.size()); | ||
| Struct update = (Struct) records.get(1).value(); | ||
| assertEquals(OperationType.UPDATE.getValue(), update.getString("operationType")); | ||
| Struct updateDescription = (Struct) update.get("updateDescription"); | ||
| assertEquals("{}", updateDescription.getString("disambiguatedPaths")); | ||
|
There was a problem hiding this comment. you might have already mentioned this offline, but why aren't we checking that it contains the expected fields similar to this example? There was a problem hiding this comment. Ah this is because I wasn't able to produce disambiguatedPaths results because trying to update a field with a There was a problem hiding this comment. I'm going to take another look at this to make sure I wasn't missing something obvious 😄 |
||
| } finally { | ||
| db.drop(); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Ensure disambiguatedPaths don't exist when showExpandedEvents is false") | ||
| void testDisambiguatedPathsDontExistWhenShowExpandedEventsIsTrue() { | ||
| assumeTrue(isAtLeastSevenDotZero()); | ||
| MongoDatabase db = getDatabaseWithPostfix(); | ||
| try (AutoCloseableSourceTask task = createSourceTask()) { | ||
| MongoCollection<Document> coll = db.getCollection("coll"); | ||
| coll.drop(); | ||
| db.createCollection(coll.getNamespace().getCollectionName(), new CreateCollectionOptions()); | ||
| HashMap<String, String> cfg = new HashMap<>(); | ||
| cfg.put( | ||
| MongoSourceConfig.OUTPUT_FORMAT_VALUE_CONFIG, | ||
| OutputFormat.SCHEMA.name().toLowerCase(Locale.ROOT)); | ||
| cfg.put(MongoSourceConfig.SHOW_EXPANDED_EVENTS_CONFIG, "false"); | ||
| task.start(cfg); | ||
| int id = 0; | ||
| Document expected = new Document("_id", id); | ||
| coll.insertOne(expected); | ||
| coll.updateOne(Filters.eq(id), Document.parse("{ $set: { foo: 1 } }")); | ||
| coll.deleteOne(Filters.eq(id)); | ||
| List<SourceRecord> records = getNextResults(task); | ||
| assertEquals(3, records.size()); | ||
| Struct update = (Struct) records.get(1).value(); | ||
| assertEquals(OperationType.UPDATE.getValue(), update.getString("operationType")); | ||
| Struct updateDescription = (Struct) update.get("updateDescription"); | ||
| assertNull(updateDescription.getString("disambiguatedPaths")); | ||
| } finally { | ||
| db.drop(); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Ensure disambiguatedPaths don't exist by default") | ||
| void testDisambiguatedPathsDontExistByDefault() { | ||
| assumeTrue(isAtLeastSevenDotZero()); | ||
| MongoDatabase db = getDatabaseWithPostfix(); | ||
| try (AutoCloseableSourceTask task = createSourceTask()) { | ||
| MongoCollection<Document> coll = db.getCollection("coll"); | ||
| coll.drop(); | ||
| db.createCollection(coll.getNamespace().getCollectionName(), new CreateCollectionOptions()); | ||
| HashMap<String, String> cfg = new HashMap<>(); | ||
| cfg.put( | ||
| MongoSourceConfig.OUTPUT_FORMAT_VALUE_CONFIG, | ||
| OutputFormat.SCHEMA.name().toLowerCase(Locale.ROOT)); | ||
| task.start(cfg); | ||
| int id = 0; | ||
| Document expected = new Document("_id", id); | ||
| coll.insertOne(expected); | ||
| coll.updateOne(Filters.eq(id), Document.parse("{ $set: { foo: 1 } }")); | ||
| coll.deleteOne(Filters.eq(id)); | ||
| List<SourceRecord> records = getNextResults(task); | ||
| assertEquals(3, records.size()); | ||
| Struct update = (Struct) records.get(1).value(); | ||
| assertEquals(OperationType.UPDATE.getValue(), update.getString("operationType")); | ||
| Struct updateDescription = (Struct) update.get("updateDescription"); | ||
| assertNull(updateDescription.getString("disambiguatedPaths")); | ||
| } finally { | ||
| db.drop(); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Ensure truncatedArrays works") | ||
| void testTruncatedArrays() { | ||
| assumeTrue(isAtLeastSixDotZero()); | ||
| MongoDatabase db = getDatabaseWithPostfix(); | ||
| try (AutoCloseableSourceTask task = createSourceTask()) { | ||
| MongoCollection<Document> coll = db.getCollection("coll"); | ||
| coll.drop(); | ||
| db.createCollection(coll.getNamespace().getCollectionName(), new CreateCollectionOptions()); | ||
| HashMap<String, String> cfg = new HashMap<>(); | ||
| cfg.put( | ||
| MongoSourceConfig.OUTPUT_FORMAT_VALUE_CONFIG, | ||
| OutputFormat.SCHEMA.name().toLowerCase(Locale.ROOT)); | ||
| task.start(cfg); | ||
| int id = 0; | ||
| Document expected = | ||
| new Document("_id", id) | ||
| .append("items", Arrays.asList(2, 30, 5, 10, 11, 100, 200, 250, 300, 5, 600)); | ||
| coll.insertOne(expected); | ||
| coll.updateOne( | ||
| Filters.eq(id), | ||
| singletonList(Document.parse("{ $set: { items: [2,30,5,10,11,100,200,250,300,5] } }"))); | ||
| coll.deleteOne(Filters.eq(id)); | ||
| List<SourceRecord> records = getNextResults(task); | ||
| assertEquals(3, records.size()); | ||
| Struct update = (Struct) records.get(1).value(); | ||
| assertEquals(OperationType.UPDATE.getValue(), update.getString("operationType")); | ||
| Struct updateDescription = (Struct) update.get("updateDescription"); | ||
|
|
||
| Schema schema = | ||
| SchemaBuilder.struct() | ||
| .name("truncatedArray") | ||
| .field("field", Schema.STRING_SCHEMA) | ||
| .field("newSize", Schema.INT32_SCHEMA) | ||
| .build(); | ||
|
|
||
| Struct truncatedArrayStruct = new Struct(schema).put("field", "items").put("newSize", 10); | ||
|
|
||
| List<Struct> expectedTruncatedArray = new ArrayList<>(); | ||
| expectedTruncatedArray.add(truncatedArrayStruct); | ||
| assertEquals(expectedTruncatedArray, updateDescription.getArray("truncatedArrays")); | ||
| } finally { | ||
| db.drop(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * We insert a document into a collection before starting the {@link MongoSourceTask}, yet we | ||
| * observe the change due to specifying {@link | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] thoughts on adding integration tests against different major versions? It looks like we're missing 6 and 7.
This can be done as part of a separate ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's a good idea, I added this ticket to the backlog.