Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPC-1053: UTCDateTime constructor should be marked as optional for Refelection #684

Closed
wants to merge 1 commit into from
Closed

PHPC-1053: UTCDateTime constructor should be marked as optional for Refelection #684

wants to merge 1 commit into from

Conversation

derickr
Copy link
Contributor

@derickr derickr commented Dec 1, 2017 •
edited by jmikola
Loading

@derickr derickr requested a review from jmikola December 1, 2017 12:09
@derickr derickr mentioned this pull request Dec 1, 2017
Closed
jmikola
jmikola approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I changed the fix version for PHPC-1053 to 1.3.4. Would you mind merging this commit into v1.3 and then up to master?

@derickr derickr force-pushed the PHPC-1053-utcdate-time branch from 05294be to f5d8efb Compare December 1, 2017 15:25
@derickr derickr changed the base branch from master to v1.3 December 1, 2017 15:25
derickr added a commit that referenced this pull request Dec 1, 2017
@derickr
Merged pull request #684
ea4d10a
@derickr derickr closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derickr @jmikola