Skip to content

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Aug 4, 2022

@blink1073 blink1073 marked this pull request as ready for review October 24, 2022 17:10
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for DRIVERS-1746 before merging.

credentials.mechanism_properties.aws_session_token,
)
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whitespace change intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, removed

@blink1073 blink1073 requested a review from juliusgeo October 27, 2022 01:12
Copy link
Contributor

@juliusgeo juliusgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit d056804 into mongodb:master Nov 14, 2022
@blink1073 blink1073 deleted the PYTHON-2818 branch November 14, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants