-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-4084 Fix BSON inflation for DBRef #1458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4ae88a1
PYTHON-4084 BSON inflation fails for CodeWithSpec objects containing …
NoahStapp 4164265
Whitespace cleanup
NoahStapp 09dabfa
Cleanup
NoahStapp 8c5cf5f
Update changelog
NoahStapp 41e3c57
Fix DBRef BSON inflation bug
NoahStapp ddf5050
Merge branch 'master' into PYTHON-4084
NoahStapp 8e490dc
reorder
NoahStapp f3ddb25
nit
NoahStapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1880,6 +1880,12 @@ static PyObject* get_value(PyObject* self, PyObject* name, const char* buffer, | |
|
|
||
| value = elements_to_dict(self, buffer + *position, | ||
| size, options); | ||
|
|
||
| if (options->is_raw_bson) { | ||
| *position += size; | ||
| break; | ||
| } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggest moving this below the !value error check. |
||
|
|
||
| if (!value) { | ||
| goto invalid; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this blank line