PYTHON-4256 Clean up handling of TOKEN_RESOURCE #1620
Merged
+69
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katcharov
reviewed
Apr 25, 2024
| "mechanism": "MONGODB-OIDC", | ||
| "mechanism_properties": { | ||
| "ENVIRONMENT": "azure", | ||
| "TOKEN_RESOURCE": "abc%2Cdef%3Aghi" |
There was a problem hiding this comment.
I think this should be abc,def:ghi? Since it's the "in code" value, which doesn't need to be encoded.
Merged
4 tasks
blink1073
changed the title
blink1073
changed the title
katcharov
reviewed
Apr 26, 2024
| @@ -541,7 +541,7 @@ | |||
| }, | |||
| { | |||
| "description": "should accept a url-encoded TOKEN_RESOURCE (MONGODB-OIDC)", | |||
| "uri": "mongodb://user@localhost/?authMechanism=MONGODB-OIDC&authMechanismProperties=ENVIRONMENT:azure,TOKEN_RESOURCE:mongodb%253A//test-cluster", | |||
| "uri": "mongodb://user@localhost/?authMechanism=MONGODB-OIDC&authMechanismProperties=ENVIRONMENT:azure,TOKEN_RESOURCE:mongodb%3A%2F%2Ftest-cluster", | |||
There was a problem hiding this comment.
When copying this file to Java:
if specified provider is not- should be "environment" not provideruld throw- two spacesexception custom callbackandPROVIDER_NAME:custom- not sure if these tests are still valid, I reverted changes
There was a problem hiding this comment.
Thanks, I had gotten out of sync.
NoahStapp
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on mongodb-labs/drivers-evergreen-tools#435