PYTHON-5126 & PYTHON-5280 Addresses issues raised in DRIVERS-3097 and DRIVERS-3123 #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caseyclements
commented
Apr 3, 2025
caseyclements
commented
- See PYTHON-5126 and DRIVERS-3123 for details.
ShaneHarvey
reviewed
Apr 3, 2025
| if padding and not n_values: | ||
| raise ValueError("Corrupt data. Vector has a padding P, but no data.") | ||
| if padding and n_values and not (unpacked_uint8s[-1] & ((1 << padding) - 1)) == 0: | ||
| raise ValueError( |
There was a problem hiding this comment.
Are these breaking changes for existing data?
There was a problem hiding this comment.
They are, yeah. But only for a case that vector search doesn't use. I feel confident that it won't affect anyone now.
There was a problem hiding this comment.
Please add a changelog entry to explain this because it's a breaking change.
3 tasks
caseyclements
changed the title
caseyclements
changed the title
blink1073
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.