Skip to content

PYTHON-5346: [v4.12] test_init_disconnected_with_srv cannot run against sharded Topologies (#2304) #2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

PYTHON-5346: [v4.12] test_init_disconnected_with_srv cannot run against sharded Topologies (#2304) #2309

merged 1 commit into from
Apr 24, 2025

Conversation

NoahStapp
Copy link
Contributor

(cherry picked from commit 34f7d7e)

@NoahStapp NoahStapp requested a review from blink1073 April 24, 2025 13:30
@NoahStapp NoahStapp changed the title PYTHON-5346: [v4.12] test_init_disconnected_with_srv cannot run against sharded Topologies (https://github.com/mongodb/mongo-python-driver/pull/2304) PYTHON-5346: [v4.12] test_init_disconnected_with_srv cannot run against sharded Topologies (#2304) Apr 24, 2025
blink1073
blink1073 approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ShaneHarvey
ShaneHarvey reviewed Apr 24, 2025
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m surprised this backport is introducing the new test rather than just the one line skip. Did we forget to backport the bug fix itself?

@NoahStapp
Copy link
Contributor Author

We forgot to backport the fix--the test is failing across the board. Separate PR or include it here?

@ShaneHarvey
Copy link
Member

Separate, to keep the history more clear.

@NoahStapp
Copy link
Contributor Author

Separate, to keep the history more clear.

Opened #2311.

@blink1073 blink1073 merged commit f5836b3 into mongodb:v4.12 Apr 24, 2025
48 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey left review comments

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoahStapp @ShaneHarvey @blink1073