Skip to content

PYTHON-5309: [v4.12] AsyncMongoClient doesn't use PyOpenSSL (#2286) #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

NoahStapp
Copy link
Contributor

No description provided.

@NoahStapp NoahStapp requested a review from blink1073 April 28, 2025 14:56
@blink1073
Copy link
Member

config file was invalid: sync with base branch & run evergreen validate -p ``

@NoahStapp
Copy link
Contributor Author

NoahStapp commented Apr 28, 2025

Ah, we need to backport our EG testing infra changes as well so the added tests here function. @blink1073 Have we backported any of those already?

@blink1073
Copy link
Member

Ah, we need to backport our EG testing infra changes as well so the added tests here function.

No, I don't think we can do that cleanly.

Weird, I am seeing this locally:

$ evergreen validate -p mongo-python-driver-release .evergreen/config.yml
...
.evergreen/config.yml is valid with warnings/notices

@blink1073
Copy link
Member

Also, I don't see anything wrong with the generated variants, they should work fine. We already had TEST_NAME support.

@NoahStapp
Copy link
Contributor Author

Ah, we need to backport our EG testing infra changes as well so the added tests here function.

No, I don't think we can do that cleanly.

Weird, I am seeing this locally:

$ evergreen validate -p mongo-python-driver-release .evergreen/config.yml
...
.evergreen/config.yml is valid with warnings/notices

The failure is on .evergreen/generated_config/variants.yml:

$ evergreen validate -p mongo-python-driver .evergreen/generated_configs/variants.yml
ERROR: load project error(s): error translating project: task selectors for build variant 'openssl-1.0.2-rhel7-python3.9' did not match any tasks

@blink1073
Copy link
Member

That should be matching these two tasks as I read it

  - name: test-5.0-standalone-auth-ssl-sync
    commands:
      - func: run server
        vars:
          VERSION: "5.0"
          TOPOLOGY: server
          AUTH: auth
          SSL: ssl
      - func: run tests
        vars:
          AUTH: auth
          SSL: ssl
          SYNC: sync
          TEST_NAME: default_sync
    tags:
      - "5.0"
      - standalone
      - auth
      - ssl
      - sync
  - name: test-5.0-standalone-auth-ssl-async
    commands:
      - func: run server
        vars:
          VERSION: "5.0"
          TOPOLOGY: server
          AUTH: auth
          SSL: ssl
      - func: run tests
        vars:
          AUTH: auth
          SSL: ssl
          SYNC: async
          TEST_NAME: default_async
    tags:
      - "5.0"
      - standalone
      - auth
      - ssl

@blink1073
Copy link
Member

Oh, you used a different project, this is mongo-python-driver-release

@blink1073
Copy link
Member

evergreen retry

@blink1073
Copy link
Member

Lol kicking it worked

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NoahStapp NoahStapp merged commit dd99f80 into mongodb:v4.12 Apr 28, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants