Skip to content

PYTHON-5429 Server command is case sensitive #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aclark4life
Copy link
Contributor

Via Erwin Pe, "libmongocrypt does case sensitive comparison of command names against the list of eligible commands."

Via Erwin Pe, "libmongocrypt does case sensitive comparison of command
names against the list of eligible commands."
@aclark4life aclark4life requested a review from a team as a code owner July 3, 2025 22:44
@aclark4life aclark4life requested a review from ShaneHarvey July 3, 2025 22:44
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"buildinfo" lowercase appears throughout our docs and test suite. Can you rename all of them?

@aclark4life
Copy link
Contributor Author

aclark4life commented Jul 3, 2025

I don't see that many but I'll fix those.

@aclark4life aclark4life requested a review from ShaneHarvey July 3, 2025 23:24
@Jibola
Copy link
Contributor

Jibola commented Jul 7, 2025

@aclark4life don't forget the buildInfo ones in the test. Based on the grep you linked:

@aclark4life
Copy link
Contributor Author

Thanks @Jibola , aecb385

@aclark4life aclark4life requested a review from Jibola July 7, 2025 15:27
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to decide if we should change this in pymongo at all. What are the cons of just waiting on the libmongocrypt bug fix release?

- Introduces a minor breaking change. When encoding :class:`bson.binary.BinaryVector`, a ``ValueError`` will be raised
if the 'padding' metadata field is < 0 or > 7, or non-zero for any type other than PACKED_BIT.
- Fixed a bug that raised ``EncryptionError`` when using :meth:`pymongo.mongo_client.MongoClient.server_info` with an
encrypted connection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another sentence explaining that server_info() now runs "buildInfo" instead of "buildinfo"? That could be a breaking change if an app is matching the command name in events or log messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants