-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5429 Server command is case sensitive #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Via Erwin Pe, "libmongocrypt does case sensitive comparison of command names against the list of eligible commands."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"buildinfo" lowercase appears throughout our docs and test suite. Can you rename all of them?
I don't see that many but I'll fix those. |
@aclark4life don't forget the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to decide if we should change this in pymongo at all. What are the cons of just waiting on the libmongocrypt bug fix release?
doc/changelog.rst
Outdated
- Introduces a minor breaking change. When encoding :class:`bson.binary.BinaryVector`, a ``ValueError`` will be raised | ||
if the 'padding' metadata field is < 0 or > 7, or non-zero for any type other than PACKED_BIT. | ||
- Fixed a bug that raised ``EncryptionError`` when using :meth:`pymongo.mongo_client.MongoClient.server_info` with an | ||
encrypted connection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add another sentence explaining that server_info() now runs "buildInfo" instead of "buildinfo"? That could be a breaking change if an app is matching the command name in events or log messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Via Erwin Pe, "libmongocrypt does case sensitive comparison of command names against the list of eligible commands."