-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5355 Addition of API to move to and from NumPy ndarrays and BSON BinaryVectors #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 11 commits
797e665
47fc92c
7882f75
b7556fb
5753e3b
d3407d7
9ae90e8
aae159f
9fadf97
40120e7
be06ce7
f03b943
3cc5041
e3b894b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,6 +66,16 @@ | |
from mmap import mmap as _mmap | ||
|
||
|
||
_NUMPY_AVAILABLE = False | ||
try: | ||
import numpy as np | ||
import numpy.typing as npt | ||
|
||
_NUMPY_AVAILABLE = True | ||
except ImportError: | ||
np = None # type: ignore | ||
|
||
|
||
class UuidRepresentation: | ||
UNSPECIFIED = 0 | ||
"""An unspecified UUID representation. | ||
|
@@ -234,13 +244,20 @@ class BinaryVector: | |
|
||
__slots__ = ("data", "dtype", "padding") | ||
|
||
def __init__(self, data: Sequence[float | int], dtype: BinaryVectorDtype, padding: int = 0): | ||
def __init__( | ||
self, | ||
data: Union[Sequence[float | int], npt.NDArray[np.number]], | ||
dtype: BinaryVectorDtype, | ||
padding: int = 0, | ||
): | ||
""" | ||
:param data: Sequence of numbers representing the mathematical vector. | ||
:param dtype: The data type stored in binary | ||
:param padding: The number of bits in the final byte that are to be ignored | ||
when a vector element's size is less than a byte | ||
and the length of the vector is not a multiple of 8. | ||
(Padding is equivalent to a negative value of `count` in | ||
`numpy.unpackbits <https://numpy.org/doc/stable/reference/generated/numpy.unpackbits.html>`_) | ||
""" | ||
self.data = data | ||
self.dtype = dtype | ||
|
@@ -424,10 +441,20 @@ def from_vector( | |
) -> Binary: | ||
... | ||
|
||
@classmethod | ||
@overload | ||
def from_vector( | ||
cls: Type[Binary], | ||
vector: npt.NDArray[np.number], | ||
dtype: BinaryVectorDtype, | ||
padding: int = 0, | ||
) -> Binary: | ||
... | ||
|
||
@classmethod | ||
def from_vector( | ||
cls: Type[Binary], | ||
vector: Union[BinaryVector, list[int], list[float]], | ||
vector: Union[BinaryVector, list[int], list[float], npt.NDArray[np.number]], | ||
dtype: Optional[BinaryVectorDtype] = None, | ||
padding: Optional[int] = None, | ||
) -> Binary: | ||
|
@@ -459,25 +486,30 @@ def from_vector( | |
vector = vector.data # type: ignore | ||
|
||
padding = 0 if padding is None else padding | ||
if dtype == BinaryVectorDtype.INT8: # pack ints in [-128, 127] as signed int8 | ||
format_str = "b" | ||
if padding: | ||
raise ValueError(f"padding does not apply to {dtype=}") | ||
elif dtype == BinaryVectorDtype.PACKED_BIT: # pack ints in [0, 255] as unsigned uint8 | ||
format_str = "B" | ||
if 0 <= padding > 7: | ||
raise ValueError(f"{padding=}. It must be in [0,1, ..7].") | ||
if padding and not vector: | ||
raise ValueError("Empty vector with non-zero padding.") | ||
elif dtype == BinaryVectorDtype.FLOAT32: # pack floats as float32 | ||
format_str = "f" | ||
if padding: | ||
raise ValueError(f"padding does not apply to {dtype=}") | ||
assert isinstance(dtype, BinaryVectorDtype) | ||
caseyclements marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
metadata = struct.pack("<sB", dtype.value, padding) | ||
|
||
if _NUMPY_AVAILABLE and isinstance(vector, np.ndarray): | ||
data = _numpy_vector_to_bytes(vector, dtype) | ||
else: | ||
raise NotImplementedError("%s not yet supported" % dtype) | ||
if dtype == BinaryVectorDtype.INT8: # pack ints in [-128, 127] as signed int8 | ||
format_str = "b" | ||
if padding: | ||
raise ValueError(f"padding does not apply to {dtype=}") | ||
elif dtype == BinaryVectorDtype.PACKED_BIT: # pack ints in [0, 255] as unsigned uint8 | ||
format_str = "B" | ||
if 0 <= padding > 7: | ||
raise ValueError(f"{padding=}. It must be in [0,1, ..7].") | ||
if padding and not vector: | ||
raise ValueError("Empty vector with non-zero padding.") | ||
elif dtype == BinaryVectorDtype.FLOAT32: # pack floats as float32 | ||
format_str = "f" | ||
if padding: | ||
raise ValueError(f"padding does not apply to {dtype=}") | ||
else: | ||
raise NotImplementedError("%s not yet supported" % dtype) | ||
data = struct.pack(f"<{len(vector)}{format_str}", *vector) # type: ignore | ||
|
||
metadata = struct.pack("<sB", dtype.value, padding) | ||
data = struct.pack(f"<{len(vector)}{format_str}", *vector) # type: ignore | ||
if padding and len(vector) and not (data[-1] & ((1 << padding) - 1)) == 0: | ||
raise ValueError( | ||
"Vector has a padding P, but bits in the final byte lower than P are non-zero. They must be zero." | ||
|
@@ -549,6 +581,33 @@ def subtype(self) -> int: | |
"""Subtype of this binary data.""" | ||
return self.__subtype | ||
|
||
def as_numpy_vector(self) -> BinaryVector: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be a new method or a new argument to the existing as_vector method? Like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm open to this as alternative to additional function There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I like Shane's suggestion, for symmetry with |
||
"""From the Binary, create a BinaryVector where data is a 1-dim numpy array. | ||
dtype still follows our typing (BinaryVectorDtype), | ||
and padding is as we define it, notably equivalent to a negative value of count | ||
in `numpy.unpackbits <https://numpy.org/doc/stable/reference/generated/numpy.unpackbits.html>`_. | ||
|
||
:return: BinaryVector | ||
|
||
.. versionadded:: 4.16 | ||
""" | ||
if self.subtype != VECTOR_SUBTYPE: | ||
raise ValueError(f"Cannot decode subtype {self.subtype} as a vector") | ||
if not _NUMPY_AVAILABLE: | ||
raise ImportError("Converting binary to numpy.ndarray requires numpy to be installed.") | ||
dtype, padding = struct.unpack_from("<sB", self, 0) | ||
dtype = BinaryVectorDtype(dtype) | ||
|
||
if dtype == BinaryVectorDtype.INT8: | ||
data = np.frombuffer(self[2:], dtype="int8") | ||
elif dtype == BinaryVectorDtype.FLOAT32: | ||
data = np.frombuffer(self[2:], dtype="float32") | ||
elif dtype == BinaryVectorDtype.PACKED_BIT: | ||
data = np.frombuffer(self[2:], dtype="uint8") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we following the rules of the spec for validating PACKED_BIT here (eg the validation in as_vector)? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just added the same validations applied in |
||
else: | ||
raise ValueError(f"Unsupported dtype code: {dtype!r}") | ||
return BinaryVector(data, dtype, padding) | ||
|
||
def __getnewargs__(self) -> Tuple[bytes, int]: # type: ignore[override] | ||
# Work around http://bugs.python.org/issue7382 | ||
data = super().__getnewargs__()[0] | ||
|
@@ -575,3 +634,32 @@ def __repr__(self) -> str: | |
return f"<Binary(REDACTED, {self.__subtype})>" | ||
else: | ||
return f"Binary({bytes.__repr__(self)}, {self.__subtype})" | ||
|
||
|
||
def _numpy_vector_to_bytes( | ||
vector: npt.NDArray[np.number], | ||
dtype: BinaryVectorDtype, | ||
) -> bytes: | ||
if not _NUMPY_AVAILABLE: | ||
raise ImportError("Converting numpy.ndarray to binary requires numpy to be installed.") | ||
|
||
assert isinstance(vector, np.ndarray) | ||
assert ( | ||
vector.ndim == 1 | ||
), "from_numpy_vector only supports 1D arrays as it creates a single vector." | ||
|
||
if dtype == BinaryVectorDtype.FLOAT32: | ||
vector = vector.astype(np.dtype("float32"), copy=False) | ||
elif dtype == BinaryVectorDtype.INT8: | ||
if vector.min() >= -128 and vector.max() <= 127: | ||
vector = vector.astype(np.dtype("int8"), copy=False) | ||
else: | ||
raise ValueError("Values found outside INT8 range.") | ||
elif dtype == BinaryVectorDtype.PACKED_BIT: | ||
if vector.min() >= 0 and vector.max() <= 127: | ||
vector = vector.astype(np.dtype("uint8"), copy=False) | ||
else: | ||
raise ValueError("Values found outside UINT8 range.") | ||
else: | ||
raise NotImplementedError("%s not yet supported" % dtype) | ||
return vector.tobytes() |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
set shell := ["bash", "-c"] | ||
|
||
# Commonly used command segments. | ||
typing_run := "uv run --group typing --extra aws --extra encryption --extra ocsp --extra snappy --extra test --extra zstd" | ||
typing_run := "uv run --group typing --extra aws --extra encryption --extra numpy --extra ocsp --extra snappy --extra test --extra zstd" | ||
|
||
docs_run := "uv run --extra docs" | ||
doc_build := "./doc/_build" | ||
mypy_args := "--install-types --non-interactive" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
numpy>=1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC importing numpy is very very slow. In that case we should not even attempt to import it by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed to lazy imports, and used
importlib.util.find_spec("numpy")
as skip condition intest_bson.py
.