RUBY-2220 Move find command construction code into operations layer #2275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
force-pushed
the
2220
branch
3 times, most recently
from
3e0f7a1 to
4781ceb
Compare
p-mongo
changed the title
p-mongo
force-pushed
the
2220
branch
3 times, most recently
from
f70fe72 to
f7cf720
Compare
comandeo
approved these changes
Jul 5, 2021
| @@ -78,7 +78,7 @@ | |||
| double('description').tap do |description| | |||
| expect(description).to receive(:mongos?) { false } | |||
| expect(description).to receive(:standalone?) { false } | |||
| expect(description).to receive(:load_balancer?) { false } | |||
| #expect(description).to receive(:load_balancer?) { false } | |||
There was a problem hiding this comment.
Maybe delete it or add a couple of words why it is commented out?
There was a problem hiding this comment.
I might need this later, I haven't actually investigated in detail why this diff makes this invocation not happen. I'll review this line before completing the epic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.