RUBY-3046 send no_cursor_timeout to server again #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvain-8422
changed the title
p-mongo
changed the title
p-mongo
approved these changes
Jul 16, 2022
comandeo
approved these changes
Jul 18, 2022
p-mongo
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Mongo::Collection::View#no_cursor_timeout regression * adjust description * add a unit test * pass no cursor timeout option to server * fix test with auth * restrict to standalones Co-authored-by: Oleg Pudeyev <code@olegp.name> Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
p-mongo
pushed a commit
that referenced
this pull request
Jul 18, 2022
* Mongo::Collection::View#no_cursor_timeout regression * adjust description * add a unit test * pass no cursor timeout option to server * fix test with auth * restrict to standalones Co-authored-by: Oleg Pudeyev <code@olegp.name> Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/RUBY-3046
Original report:
Mongo::Collection::View#no_cursor_timeoutstopped working at commit 2d9f021 (version 2.16.0).I offer a spec as proof that it is no longer working.
The spec is green at commit aab776e (last working commit).
I am myself working with MongoDB 4.4 and Ruby 2.6.
The bug also renders Mongoid's
.no_timeoutineffective (does nothing).Do not hesitate to ask me questions if something is unclear. 😄