CLOUDP-84841: Allow to update security and setparams (#631)

mongodb · Mar 15, 2021 · c5a4d65 · c5a4d65
1 parent 6bea17b
commit c5a4d65
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 11 deletions.
diff --git a/internal/convert/cluster_config.go b/internal/convert/cluster_config.go
@@ -182,12 +182,6 @@ func keepSettings(oldProcess *opsmngr.Process, newProcesses []*opsmngr.Process,
 	if oldProcess.Args26.ProcessManagement != nil {
 		newProcesses[pos].Args26.ProcessManagement = oldProcess.Args26.ProcessManagement
 	}
-	if oldProcess.Args26.Security != nil {
-		newProcesses[pos].Args26.Security = oldProcess.Args26.Security
-	}
-	if oldProcess.Args26.SetParameter != nil {
-		newProcesses[pos].Args26.SetParameter = oldProcess.Args26.SetParameter
-	}
 	if oldProcess.Args26.SNMP != nil {
 		newProcesses[pos].Args26.SNMP = oldProcess.Args26.SNMP
 	}

diff --git a/internal/convert/cluster_config_test.go b/internal/convert/cluster_config_test.go
@@ -301,6 +301,12 @@ func TestClusterConfig_PatchAutomationConfig(t *testing.T) {
 							Port:     27017,
 							Priority: pointy.Float64(1),
 							Votes:    pointy.Float64(1),
+							Security: &map[string]interface{}{
+								"test": "test",
+							},
+							SetParameter: &map[string]interface{}{
+								"test": "test",
+							},
 						},
 					},
 				},
@@ -326,9 +332,6 @@ func TestClusterConfig_PatchAutomationConfig(t *testing.T) {
 								Destination: file,
 								Path:        "/data/db/mongodb.log",
 							},
-							Security: &map[string]interface{}{
-								"test": "test",
-							},
 						},
 						LogRotate: &opsmngr.LogRotate{
 							SizeThresholdMB:  1000,
@@ -357,6 +360,12 @@ func TestClusterConfig_PatchAutomationConfig(t *testing.T) {
 								Destination: file,
 								Path:        "/data/db/mongodb.log",
 							},
+							Security: &map[string]interface{}{
+								"test": "test",
+							},
+							SetParameter: &map[string]interface{}{
+								"test": "test",
+							},
 						},
 						LogRotate: &opsmngr.LogRotate{
 							SizeThresholdMB:  1000,

diff --git a/internal/convert/process_config_test.go b/internal/convert/process_config_test.go
@@ -324,7 +324,8 @@ func Test_newReplicaSetProcess(t *testing.T) {
 			"indexConfig": map[string]interface{}{},
 		},
 		SetParameter: &map[string]interface{}{
-			"param": "param",
+			"enableLocalhostAuthBypass": "false",
+			"auditAuthorizationSuccess": "true",
 		},
 	}
 
@@ -359,7 +360,8 @@ func Test_newReplicaSetProcess(t *testing.T) {
 				Path:        "/data/log/mongodb.log",
 			},
 			SetParameter: &map[string]interface{}{
-				"param": "param",
+				"enableLocalhostAuthBypass": "false",
+				"auditAuthorizationSuccess": "true",
 			},
 		},
 		AuthSchemaVersion:           5,