Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-60957: mongocli om logs delete #131

Merged
merged 4 commits into from
Apr 27, 2020
Merged

CLOUDP-60957: mongocli om logs delete #131

merged 4 commits into from
Apr 27, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-60957

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested using my local OM

Further comments

@andreaangiolillo andreaangiolillo requested a review from gssbzn April 27, 2020 09:47
gssbzn
gssbzn requested changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small copy changes but other than that this looks great

internal/cli/ops_manager_logs_delete.go Outdated Show resolved Hide resolved
internal/cli/ops_manager_logs_delete.go Outdated Show resolved Hide resolved
andreaangiolillo and others added 2 commits April 27, 2020 10:52
@andreaangiolillo @gssbzn
Update internal/cli/ops_manager_logs_delete.go
a541d74 
Co-Authored-By: Gustavo Bazan <gssbzn@gmail.com>
@andreaangiolillo @gssbzn
Update internal/cli/ops_manager_logs_delete.go
c67fbcb 
Co-Authored-By: Gustavo Bazan <gssbzn@gmail.com>
@andreaangiolillo andreaangiolillo requested a review from gssbzn April 27, 2020 09:52
@andreaangiolillo andreaangiolillo merged commit 333be58 into master Apr 27, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-60957 branch April 27, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn