Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-124227: Update to gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #1566

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

matt-condon
Copy link
Collaborator

@matt-condon matt-condon commented Dec 15, 2022

Proposed changes

Jira ticket: CLOUDP-124227 Update to gopkg.in/yaml.v2 to gopkg.in/yaml.v3

Upgraded direct dependency for gopkg.in/yaml

An indirect dependency on v2.4.0 will remain because the viper pkg still supports and as such has a dependency on v2.4.0, but natively uses v3.0.1 by default spf13/viper#1357

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@matt-condon matt-condon requested a review from a team December 15, 2022 19:57
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-condon matt-condon merged commit a109d5f into master Dec 16, 2022
@matt-condon matt-condon deleted the CLOUDP-124227_yamlv3 branch December 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants