Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-62261: Implementing mongocli om/atlas alerts unack #163

Merged
merged 17 commits into from
May 8, 2020
Merged

CLOUDP-62261: Implementing mongocli om/atlas alerts unack #163

merged 17 commits into from
May 8, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented May 8, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-62261

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested my code using my local OM

Further comments

@andreaangiolillo andreaangiolillo requested a review from gssbzn May 8, 2020 09:35
gssbzn
gssbzn requested changes May 8, 2020
View reviewed changes
internal/cli/atlas_alerts_acknowledge.go Outdated Show resolved Hide resolved
@andreaangiolillo andreaangiolillo requested a review from gssbzn May 8, 2020 10:39
gssbzn
gssbzn reviewed May 8, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nitpick on validation but other than that this is a great improvement

internal/cli/atlas_alerts_acknowledge.go Show resolved Hide resolved
@andreaangiolillo andreaangiolillo requested a review from gssbzn May 8, 2020 10:57
@andreaangiolillo andreaangiolillo changed the title CLOUDP-62261: Update newAcknowledgeRequest to set AcknowledgedUntil as pointer CLOUDP-62261: Implementing mongocli om/atlas alerts unack May 8, 2020
gssbzn
gssbzn requested changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small nit

internal/cli/atlas_alerts_acknowledge.go Outdated Show resolved Hide resolved
@andreaangiolillo andreaangiolillo requested a review from gssbzn May 8, 2020 11:27
gssbzn
gssbzn approved these changes May 8, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/cli/atlas_alerts_acknowledge.go
Args: cobra.ExactArgs(1),
PreRunE: func(cmd *cobra.Command, args []string) error {
if opts.forever && opts.until != "" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@andreaangiolillo andreaangiolillo merged commit 67dd9b0 into master May 8, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-62261 branch May 8, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn