Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-65942: Add auto complete to brew installer #220

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jun 24, 2020

Proposed changes

Jira ticket: CLOUDP-65942

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@@ -50,11 +50,14 @@ brews:
owner: mongodb
name: homebrew-brew
folder: Formula
skip_upload: false
skip_upload: auto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking, so this means it will skip uploading rc's but will upload the tags?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rcs, betas, alpha, and such, we disabled this when we were doing our rc, so going back to not publishing unstable

Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of the rest of the process we have in place for handling the auto completion, but the change itself LGTM.

@gssbzn gssbzn merged commit 4943d4a into master Jun 24, 2020
@gssbzn gssbzn deleted the CLOUDP-65942 branch June 24, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants