Skip to content

CLOUDP-288862: Delete with latest api version #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

CLOUDP-288862: Delete with latest api version #3990

merged 3 commits into from
Jun 20, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Jun 19, 2025 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-288862

Update deletes to use the latest api version and fixes the snapshot to an old version that works until cloud-dev gets fixed

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review June 19, 2025 14:56
@blva blva requested a review from a team as a code owner June 19, 2025 14:56
fmenezes
fmenezes previously approved these changes Jun 19, 2025
View reviewed changes
@blva blva enabled auto-merge (squash) June 19, 2025 15:00
@blva blva disabled auto-merge June 19, 2025 15:06
@blva blva force-pushed the CLOUDP-288862-2 branch from b95b673 to 281bb7b Compare June 20, 2025 16:35
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report 📈

Branch Commit Coverage
master ec5e012 25.7%
CLOUDP-288862-2 99cebd5 25.7%
Difference 0%

cveticm
cveticm approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blva blva merged commit 11860fc into master Jun 20, 2025
20 of 22 checks passed
@blva blva deleted the CLOUDP-288862-2 branch June 20, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

@fmenezes fmenezes fmenezes left review comments

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @fmenezes @cveticm