Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-57631: Describe Atlas Alert #58

Merged
merged 6 commits into from
Mar 20, 2020
Merged

CLOUDP-57631: Describe Atlas Alert #58

merged 6 commits into from
Mar 20, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 20, 2020 •
edited
Loading

Jira ticket: CLOUDP-57631

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Test

Command: /bin/mongocli atlas alerts describe 5e4d20ff5cc174527c22c606

{
	"id": "5e4d20ff5cc174527c22c606",
	"groupId": "5e429f2e06822c6eac4d59c9",
	"alertConfigId": "5e429f2e06822c6eac4d59ca",
	"eventTypeName": "REPLICATION_OPLOG_WINDOW_RUNNING_OUT",
	"created": "2020-02-19T11:50:23Z",
	"updated": "2020-02-19T11:51:19Z",
	"resolved": "2020-02-19T11:51:19Z",
	"status": "CLOSED",
	"lastNotified": "2020-02-19T11:51:29Z",
	"replicaSetName": "SingleRegionCluster-shard-0"
}

@andreaangiolillo andreaangiolillo added the WIP Work in progress label Mar 20, 2020
@andreaangiolillo andreaangiolillo requested a review from gssbzn March 20, 2020 15:58
@andreaangiolillo andreaangiolillo removed the WIP Work in progress label Mar 20, 2020
gssbzn
gssbzn approved these changes Mar 20, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

internal/store/alerts.go
}

// Alert encapsulate the logic to manage different cloud providers
func (s *Store) Alert(projectID, alertID string) (*atlas.Alert, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great on just implementing what we need, makes review way easier

@andreaangiolillo andreaangiolillo merged commit fce351f into master Mar 20, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-57631 branch March 20, 2020 18:09
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
@sarahsimpers
(DOCSP-22334) Adds reference section and cluster configuration file i…
578bc77 
…nfo (mongodb#58)

* (DOCSP-22334) Adds reference section and cluster configuration file info

* Adds example files, updates required fields

* Adds multi-cloud examples

* Removes YAML examples and info

* Updates submodule to match master

* Includes changes from Corry's copy review

* Fixes build errors from primary term addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn