Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-59492 Add the status flag to the alerts list #68

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-59492 t

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested it using my local OM

Further comments

./bin/mongocli om alerts list --status OPEN --profile OPS

{
	"links": [
		{
			"rel": "self",
			"href": "http://localhost:9080/api/public/v1.0/groups/5e7b34822e676a3d207a8399/alerts?status=OPEN\u0026pageNum=1\u0026itemsPerPage=100"
		}
	],
	"results": [
		{
			"id": "5e7b47962e676a3d207a9843",
			"groupId": "5e7b34822e676a3d207a8399",
			"alertConfigId": "5e7b47692e676a3d207a9809",
			"eventTypeName": "USERS_WITHOUT_MULTI_FACTOR_AUTH",
			"created": "2020-03-25T11:59:18Z",
			"updated": "2020-03-25T12:01:15Z",
			"status": "OPEN",
			"lastNotified": "2020-03-25T11:59:25Z",
			"acknowledgedUntil": "2023-08-17T20:02:15Z",
			"acknowledgingUsername": "ydxjuumo"
		}
	],
	"totalCount": 1
}

./bin/mongocli om alerts list --status CLOSED --profile OPS

{
	"links": [
		{
			"rel": "self",
			"href": "http://localhost:9080/api/public/v1.0/groups/5e7b34822e676a3d207a8399/alerts?status=CLOSED\u0026pageNum=1\u0026itemsPerPage=100"
		}
	],
	"results": [],
	"totalCount": 0
}

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 25, 2020 17:00
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit d173104 into master Mar 26, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-59492 branch March 26, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants