CLOUDP-267957: Deployment independent resource #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
requested review from
s-urbaniak,
josvazg,
igor-karpukhin,
roothorp and
filipcirtog
igor-karpukhin
requested changes
Aug 17, 2024
s-urbaniak
reviewed
Aug 19, 2024
|
Converted to draft, as there are changes going before this one that will require heavy rebasing. |
helderjs
force-pushed
the
CLOUDP-266544-independent-dbuser
branch
from
94cc6f7 to
1c8bdff
Compare
helderjs
force-pushed
the
CLOUDP-267957-independent-deployment
branch
2 times, most recently
from
29948d6 to
f229dbc
Compare
s-urbaniak
reviewed
Oct 14, 2024
|
|
||
| func (r *AtlasDeploymentReconciler) getProjectDatabaseUsers(ctx context.Context, projectID string) ([]*akov2.AtlasDatabaseUser, error) { | ||
| databaseUsers := &akov2.AtlasDatabaseUserList{} | ||
| err := r.Client.List(ctx, databaseUsers, &client.ListOptions{}) |
There was a problem hiding this comment.
Without going through all users and filtering them manually, the deployment would not create the secrets for all the users under their project. Basically, independent deployment would update independent users, linked would update only linked. In order to keep everything in sync we have to do that.
There was a problem hiding this comment.
Sorry, I don't understand. The indexers are being updated every time a DB user resource is observed. What loss of information would we have if using a cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).