-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intgeration with official Mongo driver 2.0.0. #3941
Conversation
👍 |
a5aea8b
to
8422b9c
Compare
@durran ❤️ . |
I'm calling it 5.0 since there are going to be some API changes. |
3bbbc30
to
d775e92
Compare
1 similar comment
+1 |
+1 - this would be awesome, thank you for undertaking the work, @durran! |
+2 Romain Péchayre 2015-03-04 21:42 GMT+01:00 Carlos Lazo notifications@github.com:
|
+1 this is great! |
+1 |
Any progress on this ? How can we help ? |
Yes, we are working on it. Mongoid with the new Ruby driver (mongo gem 2.0 series) will be available soon. |
Great thank you! It looks like Mongoid is silently becoming an official MongoDB driver 👏 👏. Ready to add a 3rd 👏 if you guys give us an approximate ETA. |
hard to say exactly but very soon |
great |
👍 |
Is this anywhere near production ready? We'd be happy to push to a few machines as we're struggling with moped and the connection pool issue. |
+1 on what @simonmorley says (if you mean the 20100 limit) |
@diziet My errors are more related with moped (mongoid/moped#345) Can't use the slaves to read right now - seemly struggling for a while but had some how missed. |
please tell about planning release date |
🍻 (actually whiskey) for @durran |
Can we help anything? |
Any chance we can get a very rough ETA (days, weeks, or months)? Trying to figure out whether it's worth spending time patching moped. |
1a95d8b
to
37fd26d
Compare
\o/ |
👏 x 2^2048 |
🍺 |
Amen |
Yay! 👍 |
👍 Thanks so much! |
@durran Thanks for all the work. Looking forward to implementing. |
👍 Awesome, thanks a lot!! |
good job, thanks 👍 |
@@ -246,7 +246,7 @@ def documents | |||
# | |||
# @since 3.0.0 | |||
def results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be called result
instead of results
just because is returning one element, isn't it?
👍 |
thanks 👍 |
@@ -299,7 +299,7 @@ def output_collection | |||
# @since 3.0.0 | |||
def results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be called result instead of results just because is returning one element, the same as in geo_near.rb
congrats 👍 |
👍 |
Will remove the WIP tag and rebase against master once the work is ready for review.