Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intgeration with official Mongo driver 2.0.0. #3941

Merged
merged 27 commits into from
May 26, 2015
Merged

Conversation

durran
Copy link
Member

@durran durran commented Feb 6, 2015

Will remove the WIP tag and rebase against master once the work is ready for review.

@oliviermilla
Copy link

👍

@durran durran force-pushed the mongo-ruby-driver-2 branch 3 times, most recently from a5aea8b to 8422b9c Compare February 6, 2015 13:46
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.28%) to 92.55% when pulling 8422b9c on mongo-ruby-driver-2 into 35aea60 on master.

@arthurnn
Copy link
Contributor

arthurnn commented Feb 6, 2015

@durran ❤️ .
Would this be 5.0 , or 4.1 ?

@durran
Copy link
Member Author

durran commented Feb 6, 2015

I'm calling it 5.0 since there are going to be some API changes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.11%) to 96.72% when pulling d775e92 on mongo-ruby-driver-2 into 35aea60 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.11%) to 96.72% when pulling d775e92 on mongo-ruby-driver-2 into 35aea60 on master.

@rpechayr
Copy link

rpechayr commented Mar 2, 2015

+1

@carlosplusplus
Copy link

+1 - this would be awesome, thank you for undertaking the work, @durran!

@rpechayr
Copy link

rpechayr commented Mar 4, 2015

+2

Romain Péchayre
Co-founder and CTO Applidget
+33681544071
@rpechayr

2015-03-04 21:42 GMT+01:00 Carlos Lazo notifications@github.com:

+1


Reply to this email directly or view it on GitHub
https://github.com/mongoid/mongoid/pull/3941#issuecomment-77242674.

@fedenusy
Copy link

+1 this is great!

@Fudoshiki
Copy link
Contributor

+1

@rpechayr
Copy link

Any progress on this ? How can we help ?

@estolfo
Copy link
Contributor

estolfo commented Mar 30, 2015

Yes, we are working on it. Mongoid with the new Ruby driver (mongo gem 2.0 series) will be available soon.

@rpechayr
Copy link

Great thank you! It looks like Mongoid is silently becoming an official MongoDB driver 👏 👏. Ready to add a 3rd 👏 if you guys give us an approximate ETA.

@estolfo
Copy link
Contributor

estolfo commented Mar 31, 2015

hard to say exactly but very soon

@rpechayr
Copy link

great

@stefanhorning
Copy link

👍

@simonmorley
Copy link

Is this anywhere near production ready? We'd be happy to push to a few machines as we're struggling with moped and the connection pool issue.

@diziet
Copy link

diziet commented Apr 15, 2015

+1 on what @simonmorley says (if you mean the 20100 limit)

@simonmorley
Copy link

@diziet My errors are more related with moped (mongoid/moped#345)

Can't use the slaves to read right now - seemly struggling for a while but had some how missed.

@Fudoshiki
Copy link
Contributor

please tell about planning release date

@blasterpal
Copy link

🍻 (actually whiskey) for @durran

@Fudoshiki
Copy link
Contributor

Can we help anything?

@rpechayr
Copy link

Yes, maybe sharing what are the next step could help people be productive for this highly important milestone. @estolfo @durran @arthurnn any ideas ?

@fedenusy
Copy link

Any chance we can get a very rough ETA (days, weeks, or months)? Trying to figure out whether it's worth spending time patching moped.

@durran durran changed the title [ WIP ] Intgeration with official Mongo driver 2.0.0. Intgeration with official Mongo driver 2.0.0. May 26, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 97.83% when pulling 2d19d8d on mongo-ruby-driver-2 into d0c460a on master.

@durran durran merged commit c87b1b1 into master May 26, 2015
@durran durran deleted the mongo-ruby-driver-2 branch May 26, 2015 14:06
@jarthod
Copy link

jarthod commented May 26, 2015

\o/

@rpechayr
Copy link

👏 x 2^2048

@drobune
Copy link

drobune commented May 26, 2015

🍺

@djdarkbeat
Copy link

Amen

@thijsc
Copy link

thijsc commented May 26, 2015

Yay! 👍

@mrpoundsign
Copy link

👍 Thanks so much!

@blasterpal
Copy link

@durran Thanks for all the work. Looking forward to implementing.

@dedene
Copy link
Contributor

dedene commented May 26, 2015

👍 Awesome, thanks a lot!!

@fedenusy
Copy link

Happy Dance

@orendon
Copy link

orendon commented May 26, 2015

good job, thanks 👍

@@ -246,7 +246,7 @@ def documents
#
# @since 3.0.0
def results

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be called result instead of results just because is returning one element, isn't it?

@matuag
Copy link

matuag commented May 26, 2015

👍

@deepredsky
Copy link

thanks 👍

@@ -299,7 +299,7 @@ def output_collection
# @since 3.0.0
def results

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be called result instead of results just because is returning one element, the same as in geo_near.rb

@bmurzeau
Copy link

congrats 👍

@mdouchement
Copy link

👍

@durran durran added the fixed label May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.