MONGOID-5704 Fix performance regression on belongs_to validation #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo-mongo
approved these changes
Feb 27, 2024
Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Feb 27, 2024
…godb#5787) * MONGOID-5704 don't try to validate persisted, unchanged associations * we just need the attribute name * fix failing specs * tread very carefully so we don't trigger a load while validating * hopefully fix has-many behavior * documentation * simplify * make sure attributes getter is defined * Fix typo -- records are not loaded *from the database* Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com> --------- Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Feb 27, 2024
…godb#5787) * MONGOID-5704 don't try to validate persisted, unchanged associations * we just need the attribute name * fix failing specs * tread very carefully so we don't trigger a load while validating * hopefully fix has-many behavior * documentation * simplify * make sure attributes getter is defined * Fix typo -- records are not loaded *from the database* Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com> --------- Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
jamis
added a commit
that referenced
this pull request
Feb 27, 2024
…kport to 8.1-stable) (#5793) * MONGOID-5704 Fix performance regression on belongs_to validation (#5787) * MONGOID-5704 don't try to validate persisted, unchanged associations * we just need the attribute name * fix failing specs * tread very carefully so we don't trigger a load while validating * hopefully fix has-many behavior * documentation * simplify * make sure attributes getter is defined * Fix typo -- records are not loaded *from the database* Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com> --------- Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com> * use `rake ci` instead of `rake spec` to avoid side effects --------- Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
jamis
added a commit
that referenced
this pull request
Feb 27, 2024
…kport to 8.0-stable) (#5794) * MONGOID-5704 Fix performance regression on belongs_to validation (#5787) * MONGOID-5704 don't try to validate persisted, unchanged associations * we just need the attribute name * fix failing specs * tread very carefully so we don't trigger a load while validating * hopefully fix has-many behavior * documentation * simplify * make sure attributes getter is defined * Fix typo -- records are not loaded *from the database* Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com> --------- Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com> * use `rake ci` instead of `rake spec` to avoid side effects --------- Co-authored-by: Dmitry Rybakov <160598371+comandeo-mongo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating a belongs_to association, Mongoid was loading the associated record and validating it, which could result in a recursive chain of records being loaded and validated, even though they had been persisted and had not changed.
This PR fixes the regression by only validating the associated record if it is (1) already loaded, and (2) either new (unpersisted), or changed.