MONGOID-5843 Ensure BSON::Decimal128 is considered to be numeric (Backport to 8.1) #5964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…godb#5961) * RUBY-5843 Ensure BSON::Decimal128 is considered to be numeric * bump drivers-evergreen-tools * let's see how this version of drivers-evergreen-tools does * Revert "let's see how this version of drivers-evergreen-tools does" This reverts commit 243fc49. * don't try to run `rails new` on rails < 7.1 concurrent-ruby gem removed a dependency on logger, which rails assumed was there. Installing those versions of Rails will install a too-new version of concurrent-ruby, which causes `rails new` to fail because it can't resolve Logger.
|
I confirm this works with Rails 7.0 and Mongoid 8.1 |
comandeo-mongo
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 8.1-stable:
Because ActiveModel's
validate_numericality_ofvalidator looks at the value of a field before it was typecast, it fails when the underlying type is aBSON::Decimal128(which is not a true numeric type). This PR specializes ActiveModel'sNumericalityValidatorso that it recognizesBSON::Decimal128as a numeric type.