Skip to content

Conversation

ellnix
Copy link
Contributor

@ellnix ellnix commented Mar 20, 2025

None of them worked due to a syntax error where
set_options_for_callbacks did not accept a second argument.

I thought this fix was relatively straightforward enough to be a quick PR without going through support. Apologies if I did something incorrectly, I'm new to Mongo in general.

None of them worked due to a syntax error where
`set_options_for_callbacks` did not accept a second argument.
@ellnix
Copy link
Contributor Author

ellnix commented Mar 20, 2025

@comandeo-mongo comandeo-mongo changed the title Fix after_action_commit callbacks MONGOID-5852 Fix after_action_commit callbacks Mar 21, 2025
Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR. 👍

@jamis jamis merged commit 4e32de8 into mongodb:master Mar 21, 2025
67 checks passed
comandeo-mongo pushed a commit to comandeo-mongo/mongoid that referenced this pull request Mar 21, 2025
None of them worked due to a syntax error where
`set_options_for_callbacks` did not accept a second argument.
@jamis jamis added the bug Fixes a bug, with no new features or broken compatibility label Apr 10, 2025
@jamis jamis mentioned this pull request Apr 10, 2025
comandeo-mongo added a commit that referenced this pull request Aug 25, 2025
None of them worked due to a syntax error where
`set_options_for_callbacks` did not accept a second argument.

Co-authored-by: ellnix <ellnix@disroot.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes a bug, with no new features or broken compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants