MONGOID-5888 Ensure deeply nested children are validated correctly #6029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ongodb#6028) * MONGOID-5888 make sure nested attributes trigger validations on deeply nested children * code review feedback
There was a problem hiding this comment.
Pull Request Overview
This PR fixes validation of deeply nested children in Mongoid associations by adding a new internal flag (children_may_have_changed) to ensure that validation failures in grandchildren and deeper nested documents correctly interrupt parent document transactions.
- Introduces a new
children_may_have_changed!method and internal flag to track when nested attributes processing occurs - Updates the
children_changed?method to consider the new flag in addition to existing change detection - Modifies nested attribute builders to set the flag when processing nested attributes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/mongoid/association/referenced/has_one_models.rb | Updates test models to use polymorphic associations and adds nested attribute support with validation |
| spec/mongoid/association/referenced/has_many_models.rb | Adds new test models for has_many associations with nested attributes and validation |
| spec/integration/associations/has_one_spec.rb | Adds integration tests for deeply nested validation scenarios in has_one associations |
| spec/integration/associations/has_many_spec.rb | Adds integration tests for deeply nested validation scenarios in has_many associations |
| spec/integration/associations/has_and_belongs_to_many_spec.rb | Adds test models and integration tests for deeply nested validation in HABTM associations |
| spec/integration/associations/embeds_many_spec.rb | Adds test models and integration tests for deeply nested validation in embeds_many associations |
| lib/mongoid/changeable.rb | Implements the core logic with new flag and methods to track when children may have changed |
| lib/mongoid/association/nested/one.rb | Updates one-to-one nested attribute builder to set the children_may_have_changed flag |
| lib/mongoid/association/nested/many.rb | Updates one-to-many nested attribute builder to set the children_may_have_changed flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
comandeo-mongo
approved these changes
Aug 21, 2025
This was referenced Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 9.0-stable
With #6012 (MONGOID-5848, reverting a change that caused a performance regression), validation failures of deeply nested children (i.e. grandchildren and deeper) no longer interrupt the transaction for saving a parent. This PR addresses that by adding a new internal flag (
children_may_have_changed) that thechangedAPI now uses to indicate whether a document should validate it's children or not.The value of that flag is set to true when a child document is processed via nested attributes.