MONGOID-5895 Make Reload Properly Update new_record #6037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure reload properly handles instances where we create a new document, but set the ID to an existing one * Fix misplaced spec
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Mongoid ORM where the reload method wasn't properly updating the new_record status of documents. When a new document instance is created with an existing ID and then reloaded, it should be marked as an existing record rather than a new one.
- Sets
new_recordto false when successfully reloading a document that exists in the database - Adds comprehensive test coverage for the new behavior in different scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/mongoid/reloadable.rb | Adds logic to set @new_record = false when document is successfully reloaded from database |
| spec/mongoid/reloadable_spec.rb | Adds test cases to verify new_record status is properly updated during reload |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6034 to 9.0-stable.