feat(read-preference): unify means of read preference resolution #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvwalker
approved these changes
Jun 18, 2018
lib/utils.js
Outdated
| * properly constructed instance of `ReadPreference`. | ||
| * | ||
| * @param {Object} options The options passed into the method, potentially containing a readPreference | ||
| * @param {Object} sources Sources where we can inherit default read preference from |
There was a problem hiding this comment.
"Sources from which we can inherit default read preference"
lib/utils.js
Outdated
| * | ||
| * @param {Object} options The options passed into the method, potentially containing a readPreference | ||
| * @param {Object} sources Sources where we can inherit default read preference from | ||
| * @returns {ReadPreference} the resolved read preference, if found |
There was a problem hiding this comment.
"the" should be capitalized
kiku-jw
pushed a commit
to kiku-jw/node-mongodb-native
that referenced
this pull request
Feb 11, 2019
…godb#1738) * feat(read-preference): unify means of read preference resolution NODE-1515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE-1515