-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): test on windows [master] #2633
Conversation
…pport-windows-evergreen
…pport-windows-evergreen
|
||
const BUILD_VARIANTS = []; | ||
|
||
const getTaskList = (() => { | ||
const memo = {}; | ||
return function(mongoVersion) { | ||
const key = mongoVersion; | ||
return function (mongoVersion, onlyFullSuite = false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we removed the full-suite
tag in the 3.6 PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I missed porting that over, thanks!
.evergreen/run-tests.sh
Outdated
@@ -12,6 +12,7 @@ set -o errexit # Exit the script with error if any of the commands fail | |||
AUTH=${AUTH:-noauth} | |||
UNIFIED=${UNIFIED:-} | |||
MONGODB_URI=${MONGODB_URI:-} | |||
TEST_NPM_SCRIPT="check:test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do you actually use this variable anywhere? It doesn't look like its ever overridden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed porting over a few changes from 3.6
, done now. Sorry about the confusion!
This variable isn't strictly necessary; it is (now) used by the NO_EXIT flag logic, but that logic could easily be moved to the bottom where the npm script is executed.
.evergreen/install-dependencies.sh
Outdated
|
||
# NOTE: registry was overridden to not use artifactory, remove the `registry` line when | ||
# BUILD-6774 is resolved. | ||
|
||
# install node dependencies | ||
npm install --unsafe-perm | ||
if [[ "$SKIP_INSTALL" == "1" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [[ "$SKIP_INSTALL" == "1" ]]; then | |
if [[ "$SKIP_NPM_INSTALL" == "1" ]]; then |
nit: this is a file called "install dependencies", I would think a variable called SKIP_INSTALL
would "skip installing dependencies", but it really means "skip npm install"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also missed bringing the latest update here over from 3.6
, it now accepts a SKIP_DEPS
flag which works the way you'd think.
…pport-windows-evergreen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Run the test suite on Windows in Evergreen for the
master
branch. Port of #2634.patch build
NODE-1458
What changed?
.evergreen/install-dependencies.sh
was updated to use nvm-windows instead of nvm when running in Windows environmentsos: '!win32'
metadata directive..md
files 🏎️currently, when a test run leaks resources it sits idle until reaching our 15 minute global evergreen task timeout and being killed. This PR adds a 60 second per-task idle timeout to the driver test run on evergreen, so if a test run finishes after 5 minutes but leaks resources, the task will finish due to the idle timeout in 6 minutes rather than 15 minutes.
Are there any files to ignore?