fix(NODE-3515): do proper opTime merging in bulk results #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
durran
changed the title
nbbeeken
requested changes
Oct 20, 2021
nbbeeken
changed the title
nbbeeken
added
Team Review
dariakp
requested changes
Oct 20, 2021
lib/bulk/common.js
Outdated
| // If the opTime is a Timestamp, convert it to a consistent format to be | ||
| // able to compare easily. Converting to the object from a timestamp is | ||
| // much more straightforward than the other direction. | ||
| if (opTime._bsontype === 'Timestamp') { |
There was a problem hiding this comment.
should we have an else with an assertion about the shape to make sure that if it's unexpected we fail in a predictable manner?
There was a problem hiding this comment.
I'm not sure we need an else in this case as we basically just want to convert if that object is a timestamp and continue on. Any other value it would be at this point (only an object) is valid.
There was a problem hiding this comment.
I suppose that's fine, I was thinking about a case where the server is sending an object that doesn't have the expected shape (for example, missing or wrong type on one or both of t, ts), but that's probably low risk enough
nbbeeken
approved these changes
Oct 20, 2021
dariakp
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the merging of results in a bulk write inside a transaction to properly compare and set the
lastOpvalue in the result.What is changing?
Per various specifications,
lastOpandopTimeare optional fields in results that can be either aTimestamp, or an object with atsandtproperty ofTimestampandLongrespectively. In some cases they are bothLongs. Our comparison logic on these values could get into a hot mess when trying to compare values of different types. This changes thelastOpvalue in the bulk write result to always be an object with thetsandtfields and never sets it as aTimestampvalue anymore.Is there new documentation needed for these changes?
No
What is the motivation for this change?
This was reported as a bug in HELP-28460 and related to NODE-3515, although the user provided patch did not solve all potential cases.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>