Skip to content

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jan 6, 2022

Description

What is changing?

This PR moves 6 files from the functional directory to the integration directory.
Additionally, based on discussion with the team, this PR also

  • removes replicaset_mock.test.js
  • moves bson option tests into a node-specific folder in integration
  • move pkfactory tests into spec crud folder
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

This is a small PR that is a part of the larger NODE-3717 story to reorganize our functional tests.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the NODE-3717-separate-out-spec-tests branch from 617b25e to d178b40 Compare January 6, 2022 15:22
@baileympearson baileympearson changed the title WIP - test reorg part 7 refactor(NODE-3717): Test reorg part 7 Jan 6, 2022
@baileympearson baileympearson marked this pull request as ready for review January 6, 2022 15:51
@baileympearson baileympearson requested a review from dariakp January 6, 2022 18:51
- Address Durran's PR comments
- Remove replicaset_mock.test.js
- move pk factory tests to crud tests
- Move bson options tests to node-specific folder in integration
@dariakp dariakp merged commit 00be68f into main Jan 6, 2022
@dariakp dariakp deleted the NODE-3717-separate-out-spec-tests branch January 6, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants