Skip to content

test(NODE-4919): import mongodb-legacy in tests #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 20, 2023
Merged

test(NODE-4919): import mongodb-legacy in tests #3514

merged 11 commits into from
Jan 20, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 4, 2023 •
edited
Loading

Description

What is changing?

We use the mongodb-legacy package to continue supporting callback style tests

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken
Copy link
Contributor Author

nbbeeken commented Jan 4, 2023 •
edited
Loading

-Patch- Patch 2

@nbbeeken nbbeeken changed the title test(NODE-4918): import all driver APIs from one registry file test(NODE-4919): import mongodb-legacy in tests Jan 4, 2023
@nbbeeken nbbeeken force-pushed the NODE-4919-import-mongodb-legacy branch from 5f90950 to 5e42900 Compare January 4, 2023 22:35
@nbbeeken nbbeeken force-pushed the NODE-4918-driver-registery branch from 2cc33e8 to 565da7c Compare January 5, 2023 21:55
@nbbeeken nbbeeken force-pushed the NODE-4919-import-mongodb-legacy branch from 5e42900 to 90b2f60 Compare January 5, 2023 22:01
Base automatically changed from NODE-4918-driver-registery to main January 9, 2023 18:29
@nbbeeken nbbeeken force-pushed the NODE-4919-import-mongodb-legacy branch from 90b2f60 to abd91a3 Compare January 9, 2023 18:48
@nbbeeken nbbeeken marked this pull request as ready for review January 9, 2023 18:48
dariakp
dariakp requested changes Jan 13, 2023
View reviewed changes
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 13, 2023
@nbbeeken nbbeeken requested a review from dariakp January 13, 2023 16:46
@nbbeeken nbbeeken added the Blocked Blocked on other work label Jan 13, 2023
@nbbeeken
Copy link
Contributor Author

#3522 The linter didn't detect imports from "src" correctly so we were missing some import changes. Looking into what's wrong with the linter, but regardless we'll want those imports changed as well before this PR

@nbbeeken nbbeeken force-pushed the NODE-4919-import-mongodb-legacy branch from e31cda3 to 1a6708c Compare January 19, 2023 19:31
@nbbeeken nbbeeken removed the Blocked Blocked on other work label Jan 19, 2023
dariakp
dariakp reviewed Jan 19, 2023
View reviewed changes
dariakp
dariakp requested changes Jan 19, 2023
View reviewed changes
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 19, 2023
nbbeeken and others added 3 commits January 19, 2023 18:10
@nbbeeken nbbeeken requested a review from dariakp January 19, 2023 23:14
dariakp
dariakp reviewed Jan 19, 2023
View reviewed changes
@nbbeeken nbbeeken requested a review from dariakp January 19, 2023 23:28
dariakp
dariakp previously approved these changes Jan 20, 2023
View reviewed changes
@dariakp dariakp merged commit 056c86f into main Jan 20, 2023
@dariakp dariakp deleted the NODE-4919-import-mongodb-legacy branch January 20, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dariakp dariakp dariakp approved these changes

Assignees

No one assigned

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nbbeeken @dariakp