ci(NODE-5098): download node to local directory #3583
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,13 @@ | ||
| #! /usr/bin/env bash | ||
|
|
||
| export PATH="/opt/mongodbtoolchain/v2/bin:$PATH" | ||
|
|
||
| NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY}/node-artifacts" | ||
| if [[ "$OS" == "Windows_NT" ]]; then | ||
| NODE_ARTIFACTS_PATH=$(cygpath --unix "$NODE_ARTIFACTS_PATH") | ||
| fi | ||
|
|
||
| export PATH="$NODE_ARTIFACTS_PATH/npm_global/bin:$NODE_ARTIFACTS_PATH/nodejs/bin:$PATH" | ||
| hash -r | ||
|
|
||
| export NODE_OPTIONS="--trace-deprecation --trace-warnings" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,105 +1,95 @@ | ||
| #!/usr/bin/env bash | ||
| set -o errexit # Exit the script with error if any of the commands fail | ||
|
|
||
| NODE_LTS_NAME=${NODE_LTS_NAME:-fermium} | ||
| NODE_ARTIFACTS_PATH="${PROJECT_DIRECTORY:-$(pwd)}/node-artifacts" | ||
| if [[ "$OS" = "Windows_NT" ]]; then NODE_ARTIFACTS_PATH=$(cygpath --unix "$NODE_ARTIFACTS_PATH"); fi | ||
|
|
||
| mkdir -p "$NODE_ARTIFACTS_PATH/npm_global" | ||
|
|
||
| # Comparisons are all case insensitive | ||
| shopt -s nocasematch | ||
|
|
||
| # index.tab is a sorted tab separated values file with the following headers | ||
| # 0 1 2 3 4 5 6 7 8 9 10 | ||
| # version date files npm v8 uv zlib openssl modules lts security | ||
| curl --retry 8 -sS "https://nodejs.org/dist/index.tab" --max-time 300 --output node_index.tab | ||
|
There was a problem hiding this comment. This is a long script, could we consider breaking it into smaller functions? Or moving the logic that determines the download URL into a separate file? That might help with the readability and modularity of the script. There was a problem hiding this comment. It's shorter than the script that proceeded it, I'd like to keep it in one file to make the porting and future updating easier. Perhaps I could put functionality inside bash functions to organize it? but it will be longer as a result There was a problem hiding this comment. I don't really care about the length, if it's well organized. This file is just dense and the code is opaque. Some logical grouping might make it easier to work with in the future? There was a problem hiding this comment. If we use bash functions, we can then source this locally and test each component There was a problem hiding this comment. Is the green CI not testing enough? we can't proceed if any step in this script fails, which part is opaque, can I improve variable names? There was a problem hiding this comment. All of the logic related to finding the correct version of Node and downloading it is a little confusing, and since there's no clear boundary as to when it starts and stops, it's hard to tell when you're reading the script when that portion of code is finished. This is why we use functions, to logically group related functionality and to make understanding the higher-level purpose and logic of a script easier to GROK at a glance From a CI maintenance standpoint, ideally we never touch this code again. But if we do have to, I'd rather that it was logically group so that it's easier to reason about at the high level without reading and thoroughly understand the entire script. And yes, you're right, a green CI means the script is passing. But if we ever have to touch this again, it would be nice if we could source the file and test it in a piecemeal fashion, as opposed to testing the script in its entirety or commenting out large chunks of code to test parts of it. There was a problem hiding this comment. from slack, we're aligned on the shortness of the script and since we plan to copy it to many places we're agreed that its fine as is, we may in the future improve this if there's a significant change needed to support a platform we don't currently predict here |
||
|
|
||
| while IFS=$'\t' read -r -a row; do | ||
| node_index_version="${row[0]}" | ||
| node_index_date="${row[1]}" | ||
| node_index_lts="${row[9]}" | ||
| [[ "$node_index_version" = "version" ]] && continue # skip tsv header | ||
| [[ "$NODE_LTS_NAME" = "latest" ]] && break # first line is latest | ||
| [[ "$NODE_LTS_NAME" = "$node_index_lts" ]] && break # case insensitive compare | ||
| done < node_index.tab | ||
|
|
||
| if [[ "$OS" = "Windows_NT" ]]; then | ||
| operating_system="win" | ||
| elif [[ $(uname) = "darwin" ]]; then | ||
| operating_system="darwin" | ||
| elif [[ $(uname) = "linux" ]]; then | ||
| operating_system="linux" | ||
| else | ||
| echo "Unable to determine operating system: $operating_system" | ||
| exit 1 | ||
| fi | ||
|
|
||
| architecture=$(uname -m) | ||
| if [[ $architecture = "x86_64" ]]; then | ||
| architecture="x64" | ||
| elif [[ $architecture = "arm64" ]]; then | ||
| architecture="arm64" | ||
| elif [[ $architecture == s390* ]]; then | ||
| architecture="s390x" | ||
| elif [[ $architecture == ppc* ]]; then | ||
| architecture="ppc64le" | ||
| else | ||
| echo "Unable to determine operating system: $architecture" | ||
| exit 1 | ||
| fi | ||
|
|
||
| file_extension="tar.gz" | ||
| if [[ "$OS" = "Windows_NT" ]]; then file_extension="zip"; fi | ||
|
|
||
| node_directory="node-${node_index_version}-${operating_system}-${architecture}" | ||
| node_archive="${node_directory}.${file_extension}" | ||
| node_archive_path="$NODE_ARTIFACTS_PATH/${node_archive}" | ||
| node_download_url="https://nodejs.org/dist/${node_index_version}/${node_archive}" | ||
|
|
||
| echo "Node.js ${node_index_version} for ${operating_system}-${architecture} released on ${node_index_date}" | ||
|
|
||
| set -o xtrace | ||
|
|
||
| curl --fail --retry 8 -sS "${node_download_url}" --max-time 300 --output "$node_archive_path" | ||
|
|
||
| if [[ "$file_extension" = "zip" ]]; then | ||
| unzip -q "$node_archive_path" -d "${NODE_ARTIFACTS_PATH}" | ||
| mkdir -p "${NODE_ARTIFACTS_PATH}/nodejs" | ||
| # Windows "bins" are at the top level | ||
| mv "${NODE_ARTIFACTS_PATH}/${node_directory}" "${NODE_ARTIFACTS_PATH}/nodejs/bin" | ||
| # Need to add executable flag ourselves | ||
| chmod +x "${NODE_ARTIFACTS_PATH}/nodejs/bin/node.exe" | ||
| chmod +x "${NODE_ARTIFACTS_PATH}/nodejs/bin/npm" | ||
| else | ||
| tar -xf "$node_archive_path" -C "${NODE_ARTIFACTS_PATH}" | ||
| mv "${NODE_ARTIFACTS_PATH}/${node_directory}" "${NODE_ARTIFACTS_PATH}/nodejs" | ||
| fi | ||
|
|
||
| export PATH="$NODE_ARTIFACTS_PATH/npm_global/bin:$NODE_ARTIFACTS_PATH/nodejs/bin:$PATH" | ||
| hash -r | ||
|
|
||
| # Set npm -g prefix to our local artifacts directory | ||
| cat <<EOT > .npmrc | ||
| prefix=$NODE_ARTIFACTS_PATH/npm_global | ||
| EOT | ||
|
|
||
| if [[ $operating_system != "win" ]]; then | ||
| # Update npm to latest when we can | ||
| npm install --global npm@latest | ||
| hash -r | ||
| fi | ||
|
|
||
| echo "npm version: $(npm -v)" | ||
|
|
||
| npm install "${NPM_OPTIONS}" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| #! /bin/bash | ||
|
|
||
| source "${PROJECT_DIRECTORY}/.evergreen/init-nvm.sh" | ||
|
|
||
| export MONGODB_URI=$MONGODB_URI | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,3 +88,7 @@ etc/docs/build | |
| !docs/**/*.css | ||
| !docs/**/*.js | ||
| .nvmrc | ||
|
|
||
| node_index.tab | ||
| node-artifacts | ||
| .npmrc | ||
Uh oh!
There was an error while loading. Please reload this page.