Skip to content

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 3, 2023

Description

Backport #3583

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 7, 2023 15:56
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 9, 2023
@nbbeeken
Copy link
Contributor Author

nbbeeken commented Mar 9, 2023

evergreen retry

durran
durran previously approved these changes Mar 10, 2023
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Mar 10, 2023
@durran durran merged commit 79d774e into 4.x Mar 16, 2023
@durran durran deleted the NODE-5090-node-script branch March 16, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants