-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5484)!: mark MongoError for internal use and remove Node14 cause assignment logic #3800
Merged
Merged
Changes from 21 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
a8653ba
feat(NODE-5484)!: make MongoError constructors internal and remove No…
W-A-James d504317
fix(NODE-5484): only remove unnecessary options
W-A-James d2012c5
fix(NODE-5484): make constructors internal
W-A-James ea5ea72
test(NODE-5484): add unit tests to check that MongoCrypt Errors subcl…
W-A-James 53491bd
docs(NODE-5484): start docs update
W-A-James 55f487c
fix(NODE-5484): remove unneeded type
W-A-James ccb0866
docs(NODE-5484): update docs
W-A-James be7c2f9
docs(NODE-5484): fix diagram
W-A-James 85b02a5
docs(NODE-5484): fix diagram
W-A-James 4b1ad15
docs(NODE-5484): clean up mermaid code
W-A-James aac86bc
fix(NODE-5484): fix inheritance
W-A-James 48f7e15
fix(NODE-5484): undo unneeded change
W-A-James 6618575
fix(NODE-5484): override cause field
W-A-James ae76093
Merge branch 'main' into NODE-5484
W-A-James 1d08c4b
test(NODE-5484): fix test
W-A-James 2a58338
test(NODE-5484): update test
W-A-James 12d8aa7
test(NODE-5484): remove duplicate describe block
W-A-James 484519d
test(NODE-5484): fix unit test
W-A-James d8ee589
docs(NODE-5484): update MongoError API docs
W-A-James 0838e97
docs(NODE-5484): Refine docs
W-A-James 7120ef7
docs(NODE-5484): formatting and wording
W-A-James 414d53a
Update etc/notes/errors.md
W-A-James b51ad79
docs(NODE-5484): update docs
W-A-James 161d32b
Update etc/notes/errors.md
W-A-James 564d117
docs(NODE-5484): update wording
W-A-James aaa2ebe
fix(NODE-5484): update constructors to not take error
W-A-James 4ca5acd
test(NODE-5484): fix test assertions
W-A-James 6511534
test(NODE-5484): start fixing csfle tests
W-A-James 65c7767
fix(NODE-5484): Update error constructor calls and csfle prose tests
W-A-James 4ec65c2
test(NODE-5484): update assertion
W-A-James 56920da
test(NODE-5484): Fix test assertions
W-A-James 9d01de6
test(NODE-5484): revert test changes and update errors tests
W-A-James 25ad3a4
fix(NODE-5484): fix error message construction
W-A-James b0d687a
style(NODE-5484): remove comment
W-A-James 2cfa31d
test(NODE-5484): revert unit test
W-A-James b818f3b
test(NODE-5484): revert test change
W-A-James d24285b
test(NODE-5484): update tests to accept options
W-A-James c942e9f
test(NODE-5484): migrate MongoError.buildErrorMessage tests to unit t…
W-A-James 7553a6d
Merge branch 'main' into NODE-5484
baileympearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than linking the package, maybe we could just say that these errors are thrown from the driver's CSFLE logic?