-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(NODE-6174): use client.s.options in session #4134
Conversation
This is fine for addressing the potential slow down but how would we feel about removing the footgun? I'm thinking that the |
I think freezing is nice because it's a runtime guarantee. But why not just freeze the options once at the end of the constructor and make |
That would break the places where we write to the options object, |
It is worth noting we do have a unit test that verifies we freeze all public options, so returning |
This reverts commit f38aea5.
LGTM this should clearly have some improvement, so I'll merge this when CI completes. Did we regain the ~9% reported by devtools? |
Description
What is changing?
When constructing a
ClientSession
don't use the spread options, instead uses the options directly.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6174
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript