Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5801): use more specific key typing for multiple KMS provider support #4146

Merged
merged 4 commits into from
Jun 14, 2024
Merged

fix(NODE-5801): use more specific key typing for multiple KMS provider support #4146

merged 4 commits into from
Jun 14, 2024

Conversation

addaleax
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

nbbeeken
nbbeeken reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the minimum TS version in CI and update the README to mention the new version. Otherwise LGTM!

@nbbeeken nbbeeken self-assigned this Jun 13, 2024
@nbbeeken nbbeeken added the Team Review Needs review from team label Jun 13, 2024
nbbeeken
nbbeeken previously approved these changes Jun 13, 2024
View reviewed changes
@baileympearson baileympearson merged commit 465ffd9 into mongodb:main Jun 14, 2024
27 of 29 checks passed
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Jul 19, 2024
Open
@prernaadev01 prernaadev01 mentioned this pull request Jul 19, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Jul 19, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Jul 19, 2024
Open
@lryanle lryanle mentioned this pull request Jul 19, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Jul 19, 2024
Closed
@MohammadGhajari MohammadGhajari mentioned this pull request Jul 19, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Jul 19, 2024
Open
@lydmoon lydmoon mentioned this pull request Jul 19, 2024
Open
@mkusztal mkusztal mentioned this pull request Jul 19, 2024
Open
@brutussegun brutussegun mentioned this pull request Jul 19, 2024
Open
@akashkumar8115 akashkumar8115 mentioned this pull request Jul 20, 2024
Open
@tarun2001jawla tarun2001jawla mentioned this pull request Jul 20, 2024
Open
@ijunxyz123 ijunxyz123 mentioned this pull request Aug 25, 2024
Open
@aretexit aretexit mentioned this pull request Aug 28, 2024
Open
@mtsammy40 mtsammy40 mentioned this pull request Aug 29, 2024
Open
@jaspreetd jaspreetd mentioned this pull request Sep 2, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Sep 2, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Sep 3, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 3, 2024
Open
@lryanle lryanle mentioned this pull request Sep 3, 2024
Open
@lydmoon lydmoon mentioned this pull request Sep 3, 2024
Open
@mkusztal mkusztal mentioned this pull request Sep 3, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 4, 2024
Open
This was referenced Sep 6, 2024
Merged
Merged
@issam-seghir issam-seghir mentioned this pull request Sep 7, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 7, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 10, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 11, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Sep 11, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 13, 2024
Open
@MohammadGhajari MohammadGhajari mentioned this pull request Sep 13, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 14, 2024
Open
@McDeCoderDude McDeCoderDude mentioned this pull request Sep 14, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Sep 14, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Sep 14, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Sep 16, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 17, 2024
Open
@sunil-lakshman sunil-lakshman mentioned this pull request Sep 18, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Sep 19, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Sep 19, 2024
Open
@Habibullohnuriddin Habibullohnuriddin mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@nbbeeken nbbeeken Awaiting requested review from nbbeeken

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @nbbeeken @baileympearson